Weizhen Huang weizhen
19 Followers · 0 Following
  • Joined on 2022-10-03
Repositories
2
 Projects Public Activity Starred Repositories
Weizhen Huang pushed to equiangular-valid-range at weizhen/blender 2024-03-19 00:08:05 +01:00
b9a81dd372 Write ray_plane_intersect() utility function
Weizhen Huang pushed to equiangular-valid-range at weizhen/blender 2024-03-18 23:40:20 +01:00
afa805cca8 Support spot light with radius
eff9d1590c Fix: Cycles spot light spread sampling not considering non-uniform scaling
Compare 2 commits »
Weizhen Huang pushed to equiangular-valid-range at weizhen/blender 2024-03-18 18:52:37 +01:00
571d931d9b Fix: Cycles spot light spread sampling not considering non-uniform scaling
27c83d86fb Fix typo
Compare 2 commits »
Weizhen Huang suggested changes for blender/blender#115241 2024-03-18 13:13:19 +01:00
Fix #114780: Cycles: Principled Chiang Hair importance sampling correction

Thank you! Sorry for the delay, somehow this PR totally slipped my attention.

Weizhen Huang commented on pull request blender/blender#115241 2024-03-18 13:13:18 +01:00
Fix #114780: Cycles: Principled Chiang Hair importance sampling correction

In eval() we don't consider scale tilt for the residual component, we shouldn't change this behaviour here.

Weizhen Huang commented on pull request blender/blender#115241 2024-03-18 13:13:17 +01:00
Fix #114780: Cycles: Principled Chiang Hair importance sampling correction

I do not like this naming, because this variable has a concrete meaning and is therefore not temp, and it does not following the naming convention of the nearby code.

Weizhen Huang commented on pull request blender/blender#115241 2024-03-18 13:13:16 +01:00
Fix #114780: Cycles: Principled Chiang Hair importance sampling correction

This comment does not explain what sinThetaOp and cosThetaOp are. Maybe:

Weizhen Huang commented on pull request blender/blender#115241 2024-03-18 13:13:15 +01:00
Fix #114780: Cycles: Principled Chiang Hair importance sampling correction

Put this comment above the code, add a period at the end of sentence

Weizhen Huang commented on pull request blender/blender#115241 2024-03-18 13:13:14 +01:00
Fix #114780: Cycles: Principled Chiang Hair importance sampling correction

also change theta_i to theta_o in the comment.

Weizhen Huang commented on pull request blender/blender#119574 2024-03-16 23:32:30 +01:00
WIP: EEVEE-Next: Add light spread support

This has energy problem as the cycles version does focuses the light to keep the light power constant

This constant is normalize_spread found in intern/cycles/scene/light.cpp

Weizhen Huang pushed to main at weizhen/.profile 2024-03-16 17:38:05 +01:00
771d3afab1 Update reports/2024.md
Weizhen Huang pushed to equiangular-valid-range at weizhen/blender 2024-03-16 17:05:51 +01:00
828a52a21c Support rectangle area light with zero spread
e88a633684 Also use the new solve_quadratic function for ray-cone intersection
d7f4d4623b Support ellipse area light with zero spread
32d134c2f3 Support mesh light
9b645e9c8a Support spot light with non-uniform scaling
Compare 6 commits »
Weizhen Huang pushed to equiangular-valid-range at weizhen/blender 2024-03-15 21:49:20 +01:00
7c8b5f4ccd Support mesh light
Weizhen Huang pushed to equiangular-valid-range at weizhen/blender 2024-03-15 18:49:36 +01:00
e35b4783d6 Support spot light with non-uniform scaling
183b8d85a8 Cleanup: Cycles: remove unnecessary storage of the spot light axes
4f9c973e83 Fix: Cycles area light ignores some valid samples in volume segment
e1634437da Fix failed intersection when spread is close to pi
320208b2bc Limit the range to the positive side of the area light
Compare 89 commits »
Weizhen Huang pushed to main at blender/blender 2024-03-15 18:42:57 +01:00
b280958372 Tests: update test image due to changes in Cycles NEE
Weizhen Huang pushed to main at blender/blender-test-data 2024-03-15 18:41:24 +01:00
acf972398b Cycles: update test due to changes in NEE
Weizhen Huang commented on pull request blender/blender#119440 2024-03-15 18:34:09 +01:00
Fix: Cycles NEE not excluding self intersection

Ah, forgot to update test images before merging

Weizhen Huang deleted branch fix-nee-self-intersection from weizhen/blender 2024-03-15 18:31:37 +01:00
Weizhen Huang pushed to main at blender/blender 2024-03-15 18:31:35 +01:00
8cbc386152 Fix: Cycles NEE not excluding self intersection
Weizhen Huang merged pull request blender/blender#119440 2024-03-15 18:31:35 +01:00
Fix: Cycles NEE not excluding self intersection