Weizhen Huang weizhen
  • Joined on 2022-10-03
Weizhen Huang created branch fix-hair-firefly in weizhen/blender 2023-12-12 10:03:50 +01:00
Weizhen Huang commented on issue blender/blender#113942 2023-10-20 15:31:59 +02:00
Regression: Blender 4.0 Beta - Bump Node Issue

This is bad, the algorithm has a discontinuity when z switches the sign, so N = {0.906022, -0.423203, -0.004779} would give a T of {0.183028, 0.381608, 0.906022}, but N = {0.906022, -0.423203,…

Weizhen Huang commented on issue blender/blender#113693 2023-10-14 10:25:44 +02:00
4.0 cycles spotlights produce unwanted refraction and glare

This is a case of bad visualization. In Cycles the spotlight’s “cone of visibility” has always been wider than the overlay cone. For 4.0 you can imagine a light bulb with a lamp shade,…

Weizhen Huang approved blender/blender#112881 2023-09-26 01:32:20 +02:00
EEVEE: Add support for metallic F82 tint

Looks great! Only very very nitpicking comments.

Weizhen Huang commented on pull request blender/blender#112881 2023-09-26 01:32:20 +02:00
EEVEE: Add support for metallic F82 tint

And blue

Weizhen Huang commented on pull request blender/blender#112881 2023-09-26 01:32:19 +02:00
EEVEE: Add support for metallic F82 tint

Are theses const evaluated at compile time?

Weizhen Huang commented on pull request blender/blender#112881 2023-09-26 01:32:18 +02:00
EEVEE: Add support for metallic F82 tint

This is not F82, but a pre-integrated factor, F82 is contained in b. Maybe F82_bias or something?

Weizhen Huang commented on pull request blender/blender#112881 2023-09-26 01:32:18 +02:00
EEVEE: Add support for metallic F82 tint

F82 instead of f82.

Weizhen Huang commented on issue blender/blender#112596 2023-09-26 00:23:56 +02:00
Regression: Slower rendering performance

I’m unavailable until at least April 2024.

Weizhen Huang commented on pull request blender/blender#112848 2023-09-25 16:49:46 +02:00
Principled v2 combined changes for 4.0

Should be EEVEE in the commit messages (a59ec4c936)

Weizhen Huang commented on pull request blender/blender#112848 2023-09-25 16:45:32 +02:00
Principled v2 combined changes for 4.0

The F0 is clamped instead, following glTF (706ba4aa38)

Weizhen Huang commented on pull request blender/blender#112848 2023-09-25 16:11:24 +02:00
Principled v2 combined changes for 4.0

The EEVEE tests weren’t updated before the patch, they have some problems on Mac and look very foggy.

Weizhen Huang commented on pull request blender/blender#112848 2023-09-25 16:11:23 +02:00
Principled v2 combined changes for 4.0
Weizhen Huang commented on pull request blender/blender#112848 2023-09-25 16:11:23 +02:00
Principled v2 combined changes for 4.0

Should clarify that 1 doubles the reflectivity at normal incidence, as suggested in the pull request

Weizhen Huang commented on pull request blender/blender#112848 2023-09-25 16:11:22 +02:00
Principled v2 combined changes for 4.0

Should be something like “Tint of dielectric reflection at normal incidence or metallic reflection at near-grazing incidence”.

Weizhen Huang commented on pull request blender/blender#112848 2023-09-25 16:11:21 +02:00
Principled v2 combined changes for 4.0

… and specular to specular ior level

Weizhen Huang commented on pull request blender/blender#112551 2023-09-25 04:07:19 +02:00
Cycles: Add Metallic Tint to Principled BSDF using F82-Tint model

Seems to miss a semicolon

Weizhen Huang commented on pull request blender/blender#112552 2023-09-25 02:25:03 +02:00
Cycles/EEVEE: Change Specular input on Principled BSDF to affect IOR

Maybe “Adjust the specular reflectivity by modulating the IOR (0.5 means no adjustment, 0 removes all reflections, 1 doubles the reflectivity at normal incidence)”?

Weizhen Huang commented on pull request blender/blender#112552 2023-09-25 02:21:27 +02:00
Cycles/EEVEE: Change Specular input on Principled BSDF to affect IOR

OpenPBR does combine them

Indeed, they say “We assume that specular_ior (including any modulation via specular_ior_level as in equation ) defines n”

I don’t really like this approach…

Weizhen Huang commented on pull request blender/blender#112192 2023-09-19 19:46:37 +02:00
Cycles/EEVEE: Change specular tint in Principled BSDF from float to color

The pull request is now ready for review, with two TODOs that I probably have no time nor effort to finish. A few comments:

  • The multiscatter saturation logic of glass in EEVEE is copied from…