zazizizou/blender
0
0
Fork 0
forked from blender/blender
Code Pull Requests 1 Activity

WIP: Pan and zoom gizmos for compositor backdrop #1

Draft
Habib Gahbiche wants to merge 4 commits from com-backdrop-pan-zoom into node-pan-zoom
pull from: com-backdrop-pan-zoom
merge into: zazizizou:node-pan-zoom

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 0 Commits 4 Files Changed 10 +384 -54
Habib Gahbiche commented 2024-05-19 14:31:23 +02:00
Owner
Copy Link
pan/zoom

WIP:

<img src="/attachments/1e00067a-4a9c-4ea9-b3a4-9936864a36c3" alt="pan/zoom" width="400"/> WIP: - [ ] review/merge https://projects.blender.org/blender/blender/pulls/121941 - [ ] Use different icons for backdrop pan and zoom
pan zoom.jpg
106 KiB
Habib Gahbiche added 1 commit 2024-05-19 14:31:33 +02:00
Habib Gahbiche added 33 commits 2024-05-20 17:16:59 +02:00 
This PR adds one more stat to `ScopedTimerAveraged` for quick timing checks:
the total number of samples.

Sample output:
```
Timer 'vert_hide_update': (Average: 45.93 ms, Min: 45.93 ms, Last: 45.93 ms, Samples: 1)
```

Pull Request: blender/blender#121638
Based on the context, both names can make sense, however "translation"
seems to be the more correct term and general here.

Pull Request: blender/blender#121656
Code was wrongly using non-initialized arrays of JFA intermediate
steps. Make sure to initialize them to invalid JFA coordinate.
Jittered Soft Shadows support.
Improves soft shadow quality at the cost of re-rendering shadow maps every sample.
Disabled by default in the viewport unless enabled in the Scene settings.

| Tracing-only | Jitter-only | Jitter+Over-blur |
| --- | --- | --- |
| ![imagen](/attachments/e5ca6120-0666-4e86-b6e0-3d7512587b86) | ![imagen](/attachments/a72631aa-14f8-4e10-a748-848fc4bd4ab2) | ![imagen](/attachments/07c5de65-61d2-48e7-b78c-9c3cbdcaf844) |

Tracing-only is the method used by default in EEVEE-Next.
Jitter-only is the method used by EEVEE-Legacy Soft Shadows.
Jitter+Over-blur combines both.

Co-authored by Miguel Pozo @pragma37 (initial patch #119753)

Pull Request: blender/blender#121836
This fix the noise issue caused by shadow tracing.
This fix some missing binding errors.
* Removes unnecessary `sculpt_face_set` prefixes
* Reorganizes some methods

Pull Request: blender/blender#121895
BLF_str_offset_from_cursor_position is being called with a str_len of
INT_MAX, so max buffer size instead of string length. This works fine
right now but will not when this gets more complex. For example if we
need to call functions like BLI_str_cursor_step_next_utf8, which
assumes that str_len is the actual end of the string.

Pull Request: blender/blender#121966
Fix #121968
Previously, the tooltip was only shown when hovering over the icon.
Fix #121782

`GPencil` engine renders on the whole framebuffer.
If `Render region` is used, the result of GP rendering is scaled from whole
framebuffer down to the selected region.

The fix adds framebuffer viewport reset after rendering.
This resolves the problem for downstream consumers of
the framebuffer (e.g. `GPencil`).

The final result is somewhat similar to the `EEVEE Legacy`.
Now `EEVEE` rendering is done in the selected region, while `GPencil`
is rendered on whole viewport as before.

Pull Request: blender/blender#121979
The same as d27a1c47fa. Reroute node is
value-less and there is no actual value of input socket that should be used.

Pull Request: blender/blender#121150
Reserve comments immediately before the function for doc-strings in
the header. Otherwise both are candidates as doc-strings.
Just a general propagation of const and references, mainly for
`Object` and `SculptSession` variables, but also others.

Pull Request: blender/blender#121993
- Don't store triangulation or triangle face indices in MeshRenderData.
  This makes more automatic use of the lazy calculation and saves the
  calculation of the face indices in some cases.
- Don't use the "extractor" abstraction for the triangle index buffer.
  This is part of the ongoing transition described by #116901.
- Pass the "face sorted" data directly to the triangle index buffer
  creation. That's the only place that needs it. This makes the
  dependencies more explicit and might make better use of CPU cache.
Also remove duplicated code for creating an array of BMesh positions
Pull Request: blender/blender#121980
No functional changes.

- Remove unnecessary variable declarations.
- Declare wm & prefs at the function beginning
  to prevent noisy patches in case they're used elsewhere in the future.
- Correct invalid comment.
The function was declared in a BKE header but defined in
the sculpt_paint editors module. Move it to the slightly-less
arbitrary ED_sculpt.hh header instead.
When viewer image is drawn with offset (because of translation in compositor), the sampler doesn't consider the offset, resulting in wrong sampled values

Pull Request: blender/blender#121992
This pull request has changes conflicting with the target branch.
  • scripts/startup/bl_ui/space_node.py
  • source/blender/editors/interface/view2d_gizmo_navigate.cc
  • source/blender/editors/space_node/node_gizmo.cc
  • source/blender/editors/space_node/node_intern.hh
  • source/blender/editors/space_node/space_node.cc
  • source/blender/makesdna/DNA_space_types.h
  • source/blender/makesrna/intern/rna_space.cc
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin com-backdrop-pan-zoom:com-backdrop-pan-zoom
git checkout com-backdrop-pan-zoom
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: zazizizou/blender#1
No description provided.
Delete Branch "com-backdrop-pan-zoom"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?