Martijn Versteegh Baardaap
  • Joined on 2020-06-24
Martijn Versteegh commented on pull request blender/blender#104536 2023-02-17 19:23:50 +01:00
Eevee: GPU Material node graph optimization.

This still bugs quite hard for me. I don't even need a test file.

Just opening the default scene and switching to the shader workspace in a debug build will quit with:

BLI_assert failed:…
Martijn Versteegh pushed to activatefirstnonhiddenlayer at Baardaap/blender 2023-02-16 14:42:04 +01:00
0de0f96bd4 Revert "Never let anonymous layers be the active/render/mask/clone lauyer"
7dc47e8bdf Fix customdata_has_nonanonymous
Compare 2 commits »
Martijn Versteegh deleted branch customdata_dynamic_strings from Baardaap/blender 2023-02-16 12:40:55 +01:00
Martijn Versteegh deleted branch loadstaticstringsasdynamic from Baardaap/blender 2023-02-16 12:40:49 +01:00
Martijn Versteegh deleted branch skipanonymousuvlayers from Baardaap/blender 2023-02-15 23:55:03 +01:00
Martijn Versteegh merged pull request blender/blender#104783 2023-02-15 23:55:01 +01:00
Fix: Skip anonymous CustomData layers for the python API
Martijn Versteegh pushed to main at blender/blender 2023-02-15 23:55:01 +01:00
b1abc23899 Fix: Skip anonymous CustomData layers for the python API
Martijn Versteegh commented on pull request blender/blender#104739 2023-02-15 22:21:16 +01:00
WIP: Fix #104730: Make first visible CustomData layer active

Also, when not connecting a Texture Coordinate or UV Map node, I think the implicit uvmap is still taken from the original object and not the evaluated object. But I need to investigate that…

Martijn Versteegh pushed to skipanonymousuvlayers at Baardaap/blender 2023-02-15 21:53:17 +01:00
9483f52292 Merge branch 'main' into skipanonymousuvlayers
1e6ed77896 Merge branch 'blender-v3.5-release'
72a2229848 Fix #104690: Evaluated positions user-after-free for copied poly curves
b7e39acfcd Fix #104789: uv_layers.remove() always raises error
b07085fe3c Fix #104690: Evaluated positions user-after-free for copied poly curves
Compare 44 commits »
Martijn Versteegh pushed to skipanonymousuvlayers at Baardaap/blender 2023-02-15 21:51:44 +01:00
ecbf269d7f Revert "Use more modern syntax for the loops to count number of layers"
Martijn Versteegh commented on pull request blender/blender#104783 2023-02-15 19:33:18 +01:00
Fix: Skip anonymous CustomData layers for the python API

Hm, I have some mental problems to use the modern syntax for the new function, but leave the two analogous ones directly below it in the old synatx.

Then I'd prefer to use the same (old) syntax…

Martijn Versteegh pushed to skipanonymousuvlayers at Baardaap/blender 2023-02-15 19:20:14 +01:00
fb23cdde01 Use more modern syntax for the loops to count number of layers
65bf552140 Always skip anonymous layers.
Compare 2 commits »
Martijn Versteegh commented on pull request blender/blender#104783 2023-02-15 17:43:23 +01:00
Fix: Skip anonymous CustomData layers for the python API

Are we sure there's no place where an anonymous layer needs to be exposed to python? Probably not indeed. I'll take a look at all uses of that macro.

Martijn Versteegh commented on pull request blender/blender#104783 2023-02-15 17:41:35 +01:00
Fix: Skip anonymous CustomData layers for the python API

I'm surprised and it seems strange to give the user access to anonymous attributes. It seemed to me that this was just the specifics of the implementation of computational abstraction.

What…

Martijn Versteegh commented on pull request blender/blender#104783 2023-02-15 17:40:23 +01:00
Fix: Skip anonymous CustomData layers for the python API

Can do, but then maybe change CustomData_get_number_of_layers() as well?

Martijn Versteegh commented on pull request blender/blender#104783 2023-02-15 15:38:31 +01:00
Fix: Skip anonymous CustomData layers for the python API

Codewise it would be more logical to have CustomData_get_number_of_nonanonymous_layers() But I don't really like the 'nonanonymous' part for readability.

Martijn Versteegh created pull request blender/blender#104783 2023-02-15 15:29:14 +01:00
Fix: Skip anonymous uv layers for the python API
Martijn Versteegh created branch skipanonymousuvlayers in Baardaap/blender 2023-02-15 15:28:15 +01:00
Martijn Versteegh pushed to skipanonymousuvlayers at Baardaap/blender 2023-02-15 15:28:15 +01:00
874244e67f Fix: Skip anonymous uv layers for the python API
db2eaa5c86 OBJ: fixed some faces wrongly skipped in invalid face validation logic (#104593)
e1a29b58bb Fix: Curve resolution input node missing default
87f96b7664 Fix wrong variable being used as plan in 'gizmo_3d_dial_matrixbasis_calc'
a755e6e63f Revert "MSVC: lower C4100 warning level from 4 to 3"
Compare 10 commits »
Martijn Versteegh commented on pull request blender/blender#104536 2023-02-15 02:36:44 +01:00
Eevee: GPU Material node graph optimization.

Since this is committed the assert

BLI_assert(material != default_material);

in the function 755│ void GPU_material_set_default(GPUMaterial *material, GPUMaterial *default_material)