blender/blender

WIP: Fix #104730: Make first visible CustomData layer active #104739

Draft

Martijn Versteegh wants to merge 6 commits from Baardaap/blender:activatefirstnonhiddenlayer into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Martijn Versteegh commented

2023-02-14 13:21:44 +01:00

Member

When creating a CustomData layer with a name not starting with a dot
while all existing layers of the same type have names which do start
with a dot make the new layer the active/render/mask/clone layer.

It can be confusing if the render layers is a hidden/anonymous layer.

When creating a CustomData layer with a name not starting with a dot while all existing layers of the same type have names which do start with a dot make the new layer the active/render/mask/clone layer. It can be confusing if the render layers is a hidden/anonymous layer.

Martijn Versteegh added the

labels 2023-02-14 13:21:45 +01:00

Hans Goudey was assigned by Martijn Versteegh

2023-02-14 13:21:45 +01:00

Martijn Versteegh added 1 commit 2023-02-14 13:21:47 +01:00

Fix #104730 : Make first visible CustomData layer active 2e69a2b9af

When creating a CustomData layer with a name not starting with a dot
while all existing layers of the same type have names which do start
with a dot make the new layer the active/render/mask/clone layer.

It can be confusing if the render layers is a hidden/anonymous layer.

Martijn Versteegh commented

2023-02-14 13:22:27 +01:00

Author

Member

It's not really a satisfactory fix for this issue. I'm open to better ideas.

It's not really a satisfactory fix for this issue. I'm open to better ideas.

Iliya Katushenock commented

2023-02-14 13:24:36 +01:00

Member

Active slot switching node - open design. This looks like a partial private solution.

Active slot switching node - open design. This looks like a partial private solution.

Martijn Versteegh commented

2023-02-14 13:28:00 +01:00

Author

Member

Also, when not connecting a Texture Coordinate or UV Map node, I think the implicit uvmap is still taken from the original object and not the evaluated object. But I need to investigate that more.

Also, when not connecting a `Texture Coordinate` or `UV Map` node, I think the implicit uvmap is still taken from the original object and not the evaluated object. But I need to investigate that more.

Martijn Versteegh commented

2023-02-14 13:34:43 +01:00

Author

Member

Active slot switching node - open design. This looks like a partial private solution.

Yes, probably. But even when that node exists it is imo very undesirable that an anonymous uv map can be the active/render/mask/clone layer. This needs some thinking/designing I guess.

> Active slot switching node - open design. This looks like a partial private solution. Yes, probably. But even when that node exists it is imo very undesirable that an anonymous uv map can be the active/render/mask/clone layer. This needs some thinking/designing I guess.

Martijn Versteegh changed title from ~~Fix #104730: Make first visible CustomData layer active~~ to WIP Fix #104730: Make first visible CustomData layer active

2023-02-14 14:14:23 +01:00

Martijn Versteegh added 1 commit 2023-02-14 14:52:18 +01:00

Change for existence of 'nonanonymous' layers instead of layernames starting wwith a . 6ecfa73d6a

Brecht Van Lommel added this to the Modeling project 2023-02-15 09:51:15 +01:00

Martijn Versteegh commented

2023-02-15 22:21:15 +01:00

Author

Member

Also, when not connecting a Texture Coordinate or UV Map node, I think the implicit uvmap is still taken from the original object and not the evaluated object. But I need to investigate that more.

This turns out to not be true. However when an anonymous layer is the only uvmap on a mesh it will still be considered the render/active/etc layer and thus used for rendering. WHich behaves somewhat unexpected. Maybe an anonymous layers should just never be active/render/etc and the active(etc) layer should just be set to -1 if there are only anonymous layers.

> Also, when not connecting a `Texture Coordinate` or `UV Map` node, I think the implicit uvmap is still taken from the original object and not the evaluated object. But I need to investigate that more. This turns out to not be true. However when an anonymous layer is the *only* uvmap on a mesh it will still be considered the render/active/etc layer and thus used for rendering. WHich behaves somewhat unexpected. Maybe an anonymous layers should just never be active/render/etc and the active(etc) layer should just be set to -1 if there are only anonymous layers.

Martijn Versteegh added 2 commits 2023-02-16 14:42:17 +01:00

Fix customdata_has_nonanonymous 7dc47e8bdf

Revert "Never let anonymous layers be the active/render/mask/clone lauyer" 0de0f96bd4

This reverts commit 965a936118.

Hans Goudey changed title from ~~WIP Fix #104730: Make first visible CustomData layer active~~ to WIP: Fix #104730: Make first visible CustomData layer active

2023-02-16 14:51:35 +01:00

Hans Goudey removed their assignment 2023-02-16 18:56:29 +01:00

Martijn Versteegh commented

2023-02-23 18:01:45 +01:00

Author

Member

A better solution is maybe to remove anonymous layers from evaluated objects. (and update the 'active/render' layers as needed. (as discussed in the chat)

A better solution is maybe to remove anonymous layers from evaluated objects. (and update the 'active/render' layers as needed. (as discussed in the chat)

Martijn Versteegh commented

2023-02-24 21:16:13 +01:00

Author

Member

I think this should maybe still be useful to add after #105192, maybe after some reworking.

I think this should maybe still be useful to add after #105192, maybe after some reworking.

Jacques Lucke commented

2023-03-21 15:15:50 +01:00

Member

The referenced bug is closed, can this PR be closed as well?

The referenced bug is closed, can this PR be closed as well?

Martijn Versteegh commented

2023-03-21 19:34:21 +01:00

Author

Member

Not sure yet. Part of this fix didn't make it into what was merged. We might need some discussion if it's still needed.

The part that was merged suppresses the usage of anonymous layers for rendering, which prevents the most confusing behavior, but the anonymous layer can still be the 'render' layer or the 'active' layer.

I think it would be a good idea to set the first 'nonanonymous' layer to the active/render/clone layer. But maybe that should wait till the whole system of which layer is 'active' is changed to name based like with the color attributes?.

Not sure yet. Part of this fix didn't make it into what was merged. We might need some discussion if it's still needed. The part that was merged suppresses the usage of anonymous layers for rendering, which prevents the most confusing behavior, but the anonymous layer can still be the 'render' layer or the 'active' layer. I think it would be a good idea to set the first 'nonanonymous' layer to the active/render/clone layer. But maybe that should wait till the whole system of which layer is 'active' is changed to name based like with the color attributes?.

This pull request has changes conflicting with the target branch.

source/blender/blenkernel/intern/customdata.cc

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u activatefirstnonhiddenlayer:Baardaap-activatefirstnonhiddenlayer

git checkout Baardaap-activatefirstnonhiddenlayer

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Viewport & EEVEE

Virtual Reality

Asset Browser Project

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Viewport & EEVEE

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104739

No description provided.