BogdanNagirniak/blender-addons
0
1
Fork 2
forked from blender/blender-addons
Code Pull Requests Activity

Caching generated image leads to infinite loop in preview render #15

Merged
Bogdan Nagirniak merged 3 commits from BLEN-409 into materialx-addon 2023-06-13 18:51:41 +02:00
Conversation 0 Commits 3 Files Changed 1 +14 -5
Georgiy Markelov commented 2023-06-08 13:59:41 +02:00
Collaborator
Copy Link

Purpose

Fix infinite loop in preview render when generated image cached.

Technical steps

Caching images moved from python to C++ part so caching no more triggers Depsgraph updates;

### Purpose Fix infinite loop in preview render when generated image cached. ### Technical steps Caching images moved from python to C++ part so caching no more triggers Depsgraph updates;
Georgiy Markelov self-assigned this 2023-06-08 13:59:41 +02:00
Brian Savery (AMD) was assigned by Georgiy Markelov 2023-06-08 13:59:41 +02:00
Vasyl Pidhirskyi was assigned by Georgiy Markelov 2023-06-08 13:59:41 +02:00
Bogdan Nagirniak was assigned by Georgiy Markelov 2023-06-08 13:59:41 +02:00
Georgiy Markelov added 2 commits 2023-06-08 13:59:43 +02:00
Georgiy Markelov requested review from Brian Savery (AMD) 2023-06-08 13:59:48 +02:00
Georgiy Markelov requested review from Vasyl Pidhirskyi 2023-06-08 13:59:48 +02:00
Brian Savery (AMD) approved these changes 2023-06-08 21:27:21 +02:00
Vasyl Pidhirskyi approved these changes 2023-06-09 11:46:03 +02:00
Vasyl Pidhirskyi left a comment
Collaborator
Copy Link

Looks good.

Looks good.
Bogdan Nagirniak added 1 commit 2023-06-13 07:45:53 +02:00
Bogdan Nagirniak approved these changes 2023-06-13 08:01:25 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Moved _bpy_hydra.cache_or_get_image_file() usage to the beginning of cache_image_file() as more correct

Moved `_bpy_hydra.cache_or_get_image_file()` usage to the beginning of `cache_image_file()` as more correct
Bogdan Nagirniak merged commit 5103b7f446 into materialx-addon 2023-06-13 18:51:41 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Vasyl Pidhirskyi
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Georgiy Markelov
Brian Savery (AMD)
Vasyl Pidhirskyi
Bogdan Nagirniak
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender-addons#15
No description provided.
Delete Branch "BLEN-409"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?