BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Caching generated image leads to infinite loop in preview render #53

Merged
Bogdan Nagirniak merged 12 commits from BLEN-409 into hydra-render 2023-06-13 18:39:39 +02:00
Conversation 0 Commits 12 Files Changed 4 +42 -32
Georgiy Markelov commented 2023-06-08 13:57:31 +02:00
Collaborator
Copy Link

Purpose

Fix infinite loop in preview render when generated image cached.

Technical steps

Caching images moved from python to C++ part so caching no more triggers Depsgraph updates;
Added cache_image_func;
Fixed caching logic;

Note for reviewers

Use with BogdanNagirniak/blender-addons#15

### Purpose Fix infinite loop in preview render when generated image cached. ### Technical steps Caching images moved from python to C++ part so caching no more triggers Depsgraph updates; Added `cache_image_func`; Fixed caching logic; ### Note for reviewers Use with https://projects.blender.org/BogdanNagirniak/blender-addons/pulls/15
Georgiy Markelov self-assigned this 2023-06-08 13:57:31 +02:00
Brian Savery (AMD) was assigned by Georgiy Markelov 2023-06-08 13:57:31 +02:00
Vasyl Pidhirskyi was assigned by Georgiy Markelov 2023-06-08 13:57:31 +02:00
Bogdan Nagirniak was assigned by Georgiy Markelov 2023-06-08 13:57:31 +02:00
Georgiy Markelov added 4 commits 2023-06-08 13:57:45 +02:00
Georgiy Markelov requested review from Brian Savery (AMD) 2023-06-08 13:57:52 +02:00
Georgiy Markelov requested review from Vasyl Pidhirskyi 2023-06-08 13:57:53 +02:00
Brian Savery (AMD) approved these changes 2023-06-08 21:27:40 +02:00
Georgiy Markelov added 2 commits 2023-06-09 09:48:23 +02:00
Bogdan Nagirniak requested changes 2023-06-09 10:04:42 +02:00
source/blender/render/hydra/python.cc Outdated
@ -227,4 +243,3 @@
{"engine_create", engine_create_func, METH_VARARGS, ""},
{"engine_free", engine_free_func, METH_VARARGS, ""},
{"engine_sync", engine_sync_func, METH_VARARGS, ""},
{"engine_sync_usd", engine_sync_usd_func, METH_VARARGS, ""},
Bogdan Nagirniak commented 2023-06-09 10:03:43 +02:00
Owner
Copy Link

why did you remove this?

why did you remove this?
Georgiy Markelov commented 2023-06-09 10:51:35 +02:00
Author
Collaborator
Copy Link

Mistake. Fixed.

Mistake. Fixed.
DagerD marked this conversation as resolved
Georgiy Markelov added 2 commits 2023-06-09 10:50:40 +02:00
Vasyl Pidhirskyi approved these changes 2023-06-09 20:42:21 +02:00
Vasyl Pidhirskyi left a comment
Collaborator
Copy Link

Looks good.

Looks good.
Bogdan Nagirniak added 2 commits 2023-06-13 07:07:29 +02:00
Bogdan Nagirniak added 1 commit 2023-06-13 07:50:02 +02:00 
Simplified cache_image_file()
Bogdan Nagirniak added 1 commit 2023-06-13 07:53:26 +02:00
Bogdan Nagirniak approved these changes 2023-06-13 07:56:18 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Added code improvements + changes in MaterialX addon. Tested - works good

Added code improvements + changes in MaterialX addon. Tested - works good
Bogdan Nagirniak merged commit bf4b914f28 into hydra-render 2023-06-13 18:39:39 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Vasyl Pidhirskyi
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Brian Savery (AMD)
Vasyl Pidhirskyi
Bogdan Nagirniak
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#53
No description provided.
Delete Branch "BLEN-409"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?