BogdanNagirniak/blender-addons
0
1
Fork 2
forked from blender/blender-addons
Code Pull Requests Activity

BLEN-358: Error in console after closing Blender #4

Merged
Bogdan Nagirniak merged 2 commits from BLEN-358_1 into materialx-addon 2023-04-11 17:16:30 +02:00
Conversation 0 Commits 2 Files Changed 2 +63 -10
Georgiy Markelov commented 2023-03-17 15:11:41 +01:00
Collaborator
Copy Link

PURPOSE
Method RenderEngine.__del__ isn't called and it leads to error in console after closing Blender.
This exception is the reason why RenderEngine.__del__ isn't called
https://projects.blender.org/BogdanNagirniak/blender-addons/src/commit/61dd62cb6d41c3fe1886bbee109bc0faa1165a69/materialx/nodes/init.py#L74

TECHNICAL STEPS
Added check for input types and warnings if input has inappropriate type. This check added for Mix and Add nodes for now.

**PURPOSE** Method `RenderEngine.__del__` isn't called and it leads to error in console after closing Blender. This exception is the reason why `RenderEngine.__del__` isn't called [https://projects.blender.org/BogdanNagirniak/blender-addons/src/commit/61dd62cb6d41c3fe1886bbee109bc0faa1165a69/materialx/nodes/__init__.py#L74](https://projects.blender.org/BogdanNagirniak/blender-addons/src/commit/61dd62cb6d41c3fe1886bbee109bc0faa1165a69/materialx/nodes/__init__.py#L74) **TECHNICAL STEPS** Added check for input types and warnings if input has inappropriate type. This check added for `Mix` and `Add` nodes for now.
Georgiy Markelov added 1 commit 2023-03-17 15:11:42 +01:00
Georgiy Markelov added 1 commit 2023-03-20 15:06:56 +01:00
Bogdan Nagirniak approved these changes 2023-04-11 17:15:32 +02:00
Bogdan Nagirniak merged commit bcc93b0452 into materialx-addon 2023-04-11 17:16:30 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender-addons#4
No description provided.
Delete Branch "BLEN-358_1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?