BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

BLEN-358: Error in console after closing Blender #22

Merged
Bogdan Nagirniak merged 4 commits from BLEN-358_1 into hydra-render 2023-04-06 11:58:30 +02:00
Conversation 0 Commits 4 Files Changed 1 +6
Georgiy Markelov commented 2023-04-04 16:32:21 +02:00
Collaborator
Copy Link

Purpose
BogdanNagirniak/blender-addons#4 doesn’t fix fully fix issue.

Technical steps
Added catching and print exception on Python side.

**Purpose** https://projects.blender.org/BogdanNagirniak/blender-addons/pulls/4 doesn’t fix fully fix issue. **Technical steps** Added catching and print exception on Python side.
Georgiy Markelov added 1 commit 2023-04-04 16:32:30 +02:00
Brian Savery (AMD) was assigned by Georgiy Markelov 2023-04-04 16:32:43 +02:00
Georgiy Markelov self-assigned this 2023-04-04 16:32:43 +02:00
Bogdan Nagirniak was assigned by Georgiy Markelov 2023-04-04 16:32:43 +02:00
Georgiy Markelov requested review from Brian Savery (AMD) 2023-04-04 16:32:48 +02:00
Brian Savery (AMD) approved these changes 2023-04-05 00:47:07 +02:00
Bogdan Nagirniak requested changes 2023-04-05 15:49:09 +02:00
scripts/modules/bpy_hydra.py Outdated
@ -109,0 +109,4 @@
try:
doc = mx_utils.export(material, None)
except:
traceback.print_exc()
Bogdan Nagirniak commented 2023-04-05 15:48:57 +02:00
Owner
Copy Link

Move this to end of function with comment like "Important: code shouldn't raise any exception ...."

Move this to end of function with comment like "Important: code shouldn't raise any exception ...."
DagerD marked this conversation as resolved
Georgiy Markelov added 1 commit 2023-04-06 11:47:04 +02:00
Bogdan Nagirniak reviewed 2023-04-06 11:51:01 +02:00
scripts/modules/bpy_hydra.py
@ -119,0 +121,4 @@
# This code shouldn't raise any exception due to breaking refcounts on RenderEngine
except:
traceback.print_exc()
return ""
Bogdan Nagirniak commented 2023-04-06 11:50:53 +02:00
Owner
Copy Link

remove return "" from here, move comment under except:

remove `return ""` from here, move comment under `except:`
DagerD marked this conversation as resolved
Georgiy Markelov added 1 commit 2023-04-06 11:54:11 +02:00 
fix review comments
Georgiy Markelov added 1 commit 2023-04-06 11:56:02 +02:00 
fix indentation
Bogdan Nagirniak approved these changes 2023-04-06 11:56:52 +02:00
Bogdan Nagirniak merged commit 8e6611dabe into hydra-render 2023-04-06 11:58:30 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Brian Savery (AMD)
Bogdan Nagirniak
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#22
No description provided.
Delete Branch "BLEN-358_1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?