BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

BLEN-351: Test/fix Hydra addon with different blender scenes #13

Merged
Bogdan Nagirniak merged 4 commits from BLEN-351 into hydra-render 2023-03-10 17:16:57 +01:00
Conversation 0 Commits 4 Files Changed 4 +13 -7
Georgiy Markelov commented 2023-03-10 11:03:12 +01:00
Collaborator
Copy Link
  • added check for empty mesh returned by object.to_mesh() function
  • added check for world input node
  • removed OB_CURVES from list of supported objects
* added check for empty mesh returned by object.to_mesh() function * added check for world input node * removed OB_CURVES from list of supported objects
Georgiy Markelov added 3 commits 2023-03-10 11:03:23 +01:00 
fixed check for supported objects
Georgiy Markelov requested review from Brian Savery (AMD) 2023-03-10 11:04:15 +01:00
Bogdan Nagirniak requested changes 2023-03-10 14:56:27 +01:00
source/blender/render/hydra/sceneDelegate/blenderSceneDelegate.cc
@ -221,2 +223,3 @@
if (!obj_data) {
objects[id] = ObjectData::init(this, object);
unique_ptr<ObjectData> new_object = ObjectData::init(this, object);
if (!new_object) {
Bogdan Nagirniak commented 2023-03-10 14:53:47 +01:00
Owner
Copy Link

It shouldn't be nullptr here, please check.

It shouldn't be nullptr here, please check.
BogdanNagirniak marked this conversation as resolved
Georgiy Markelov added 1 commit 2023-03-10 16:20:25 +01:00
Bogdan Nagirniak approved these changes 2023-03-10 17:15:44 +01:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Looks good

Looks good
Bogdan Nagirniak merged commit 4697cf25da into hydra-render 2023-03-10 17:16:57 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#13
No description provided.
Delete Branch "BLEN-351"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?