BLEN-368: Fixes in hydra.py #15

Merged

Bogdan Nagirniak merged 2 commits from BLEN-368 into hydra-render 2023-03-16 14:43:06 +01:00

Conversation 0 Commits 2 Files Changed 6 +141 -94

Bogdan Nagirniak commented 2023-03-15 17:46:05 +01:00

Owner

Copy Link

Purpose

Fixing review comments blender/blender#104712 related to release/scripts/modules/hydra.py module.

Technical steps

1. Renamed module hydra.py -> bpy_hydra.py.
2. Renamed internal module _hydra -> _bpy_hydra.
3. Added docstrings to bpy_hydra.py with example of CustomHydraRenderEngine.
4. Removed traceback and Exception catch in export_mtlx().
5. Changed MaterialData::export_mtlx() to send material object directly.

### Purpose Fixing review comments https://projects.blender.org/blender/blender/pulls/104712 related to release/scripts/modules/hydra.py module. ### Technical steps 1. Renamed module hydra.py -> bpy_hydra.py. 2. Renamed internal module `_hydra` -> `_bpy_hydra`. 3. Added docstrings to bpy_hydra.py with example of CustomHydraRenderEngine. 4. Removed `traceback` and Exception catch in `export_mtlx()`. 5. Changed `MaterialData::export_mtlx()` to send material object directly.

Brian Savery (AMD) was assigned by Bogdan Nagirniak 2023-03-15 17:46:05 +01:00

Georgiy Markelov was assigned by Bogdan Nagirniak 2023-03-15 17:46:05 +01:00

Bogdan Nagirniak self-assigned this 2023-03-15 17:46:05 +01:00

Bogdan Nagirniak added 2 commits 2023-03-15 17:46:14 +01:00

eaece96147 BLEN-368: Fixes in hydra.py ...

Renamed hydra.py -> bpy_hydra.py.
Renamed internal py module _hydra -> _bpy_hydra.py
Removed Exception catch in export_mtlx()

ba6de9a2de Added documentation for HydraRenderEngine with example. ...

Changed export_mtlx to use material RNA object.

Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-03-15 17:46:23 +01:00

Bogdan Nagirniak requested review from Georgiy Markelov 2023-03-15 17:46:24 +01:00

Georgiy Markelov approved these changes 2023-03-16 14:01:03 +01:00

Bogdan Nagirniak merged commit 14e7eedfd6 into hydra-render 2023-03-16 14:43:06 +01:00

Bogdan Nagirniak referenced this issue from a commit 2023-03-16 14:43:06 +01:00

BLEN-368: Fixes in hydra.py

Sign in to join this conversation.

Reviewers

No reviewers

Brian Savery (AMD)

Georgiy Markelov

Labels

Clear labels

No items

No Label

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

Brian Savery (AMD)

Bogdan Nagirniak

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#15

No description provided.