BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

BLEN-370: Find way not to modify PATH #17

Merged
Bogdan Nagirniak merged 3 commits from BLEN-370 into hydra-render 2023-03-23 12:59:22 +01:00
Conversation 0 Commits 3 Files Changed 4 +9 -67
Georgiy Markelov commented 2023-03-20 21:28:07 +01:00
Collaborator
Copy Link

PURPOSE
Move modifying env variables from Blender code to plugin side.

TECHNICAL STEPS

  • Removed setting env variables in Blender code.
  • Removed unused code.

NOTE FOR REVIEWERS
Use with:
https://github.com/bnagirniak/RPRHydraRenderBlenderAddon/pull/11

**PURPOSE** Move modifying env variables from Blender code to plugin side. **TECHNICAL STEPS** * Removed setting env variables in Blender code. * Removed unused code. **NOTE FOR REVIEWERS** Use with: https://github.com/bnagirniak/RPRHydraRenderBlenderAddon/pull/11
Georgiy Markelov added 1 commit 2023-03-20 21:28:19 +01:00
Georgiy Markelov requested review from Brian Savery (AMD) 2023-03-20 21:28:29 +01:00
Brian Savery (AMD) was assigned by Bogdan Nagirniak 2023-03-21 12:51:33 +01:00
Georgiy Markelov was assigned by Bogdan Nagirniak 2023-03-21 12:51:33 +01:00
Bogdan Nagirniak self-assigned this 2023-03-21 12:51:34 +01:00
Bogdan Nagirniak requested changes 2023-03-22 11:58:52 +01:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Update example comment of HydraRenderEngine usage in bpy_hydra.py

Update example comment of HydraRenderEngine usage in bpy_hydra.py
source/blender/render/hydra/python.cc Outdated
@ -36,4 +21,0 @@
return;
}
set_env_paths("PXR_MTLX_STDLIB_SEARCH_PATHS", {stdlib_path});
Bogdan Nagirniak commented 2023-03-22 11:54:23 +01:00
Owner
Copy Link

I think this should be set in C++ part. Check with Brecht.

I think this should be set in C++ part. Check with Brecht.
Georgiy Markelov added 1 commit 2023-03-23 11:03:20 +01:00
Georgiy Markelov added 1 commit 2023-03-23 11:16:00 +01:00
Bogdan Nagirniak approved these changes 2023-03-23 12:58:58 +01:00
Bogdan Nagirniak merged commit 34e1d9e631 into hydra-render 2023-03-23 12:59:22 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Brian Savery (AMD)
Bogdan Nagirniak
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#17
No description provided.
Delete Branch "BLEN-370"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?