BogdanNagirniak
/
blender
forked from blender/blender
0
0
Fork 3
Code Pull Requests Activity

BLEN-372: Fix copying hdStorm and usdShaders libraries #18

Merged
Bogdan Nagirniak merged 5 commits from build-fix into hydra-render 2023-03-24 18:11:29 +01:00
Conversation 0 Commits 5 Files Changed 8 +21 -34
Bogdan Nagirniak commented 2023-03-23 11:24:00 +01:00
Owner
Copy Link

Purpose

Fix build code due to code review comments.

Technical steps

  1. Set WITH_HYDRA option ON for all platforms.
  2. Removed unnecessary build flags.
  3. Removed copying plugin/usd/hdStorm, it has to be moved to Hydra storm addon

Notes

Storm is working with BogdanNagirniak/blender-addons#6

### Purpose Fix build code due to code review comments. ### Technical steps 1. Set WITH_HYDRA option ON for all platforms. 2. Removed unnecessary build flags. 3. Removed copying plugin/usd/hdStorm, it has to be moved to Hydra storm addon ### Notes Storm is working with https://projects.blender.org/BogdanNagirniak/blender-addons/pulls/6
Brian Savery (AMD) was assigned by Bogdan Nagirniak 2023-03-23 11:24:00 +01:00
Georgiy Markelov was assigned by Bogdan Nagirniak 2023-03-23 11:24:00 +01:00
Bogdan Nagirniak self-assigned this 2023-03-23 11:24:00 +01:00
Bogdan Nagirniak added 3 commits 2023-03-23 11:24:10 +01:00
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-03-23 11:24:16 +01:00
Bogdan Nagirniak requested review from Georgiy Markelov 2023-03-23 11:24:16 +01:00
Georgiy Markelov reviewed 2023-03-23 17:16:13 +01:00
Georgiy Markelov left a comment
Collaborator
Copy Link

Check this BogdanNagirniak/blender-addons#6 (comment) first please

Check this https://projects.blender.org/BogdanNagirniak/blender-addons/pulls/6#issuecomment-907095 first please
Bogdan Nagirniak added 1 commit 2023-03-24 09:03:35 +01:00
Bogdan Nagirniak added 1 commit 2023-03-24 15:36:09 +01:00
Georgiy Markelov approved these changes 2023-03-24 17:34:06 +01:00
Bogdan Nagirniak changed title from Fix/cleanup build to BLEN-372: Fix copying hdStorm and usdShaders libraries 2023-03-24 17:58:25 +01:00
Bogdan Nagirniak merged commit 269deec0f6 into hydra-render 2023-03-24 18:11:29 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Georgiy Markelov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Brian Savery (AMD)
Bogdan Nagirniak
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#18
No description provided.
Delete Branch "build-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?