BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

BLEN-359: Implement updates for instances in viewport #20

Merged
Bogdan Nagirniak merged 20 commits from BLEN-359_1 into hydra-render 2023-04-05 11:47:37 +02:00
Conversation 0 Commits 20 Files Changed 18 +681 -477
Bogdan Nagirniak commented 2023-03-31 14:16:36 +02:00
Owner
Copy Link

Purpose

Instances aren't correctly applied in scene delegate + updates instances in viewport isn't working.

Technical steps

  1. Refactoring:
    • updated interface of IdData class: added base methods init() insert() remove() update() which should be overrided in child classes
    • moved object update to update() instead recreation of IdData
  2. Implemented InstancerData class.
    • moved instancer related code to InstancerData, improved working with instances transforms
    • adjusted BlenderSceneDelegate code to work with InstancerData
  3. Implemented updates of instanced due to:
    • parent object changes: transform, mesh changes, add/remove
    • base mesh changes: transform, mesh changes, add/remove

Notes

This is not final changes in instances here. We work only with one instancer for parent object, but it could have several instancers.

### Purpose Instances aren't correctly applied in scene delegate + updates instances in viewport isn't working. ### Technical steps 1. Refactoring: * updated interface of IdData class: added base methods `init() insert() remove() update()` which should be overrided in child classes * moved object update to `update()` instead recreation of IdData 2. Implemented InstancerData class. * moved instancer related code to InstancerData, improved working with instances transforms * adjusted BlenderSceneDelegate code to work with InstancerData 3. Implemented updates of instanced due to: * parent object changes: transform, mesh changes, add/remove * base mesh changes: transform, mesh changes, add/remove ### Notes This is not final changes in instances here. We work only with one instancer for parent object, but it could have several instancers.
Brian Savery (AMD) was assigned by Bogdan Nagirniak 2023-03-31 14:16:36 +02:00
Georgiy Markelov was assigned by Bogdan Nagirniak 2023-03-31 14:16:36 +02:00
Bogdan Nagirniak self-assigned this 2023-03-31 14:16:36 +02:00
Bogdan Nagirniak added 19 commits 2023-03-31 14:16:50 +02:00 
Added p_id to IdData.
Removed SampleInstancerTransform as not used.
Fixed searching Surface socket in world nodetree.
Improvements in other objects export.
Formatted code
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-03-31 14:17:26 +02:00
Bogdan Nagirniak requested review from Georgiy Markelov 2023-03-31 14:17:27 +02:00
Georgiy Markelov approved these changes 2023-03-31 19:17:23 +02:00
Georgiy Markelov left a comment
Collaborator
Copy Link

Tested. Further fixes will be done in other tasks.

Tested. Further fixes will be done in other tasks.
Brian Savery (AMD) approved these changes 2023-04-05 00:49:00 +02:00
Bogdan Nagirniak added 1 commit 2023-04-05 11:46:30 +02:00 
Fixed adding only one object instance.
Bogdan Nagirniak merged commit 5dff356a4e into hydra-render 2023-04-05 11:47:37 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Georgiy Markelov
Brian Savery (AMD)
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Brian Savery (AMD)
Bogdan Nagirniak
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#20
No description provided.
Delete Branch "BLEN-359_1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?