BogdanNagirniak
/
blender
forked from blender/blender
0
0
Fork 3
Code Pull Requests Activity

Support several instancers on one object #24

Merged
Bogdan Nagirniak merged 16 commits from BLEN-383 into hydra-render 2023-04-19 02:46:24 +02:00
Conversation 0 Commits 16 Files Changed 10 +455 -284
Bogdan Nagirniak commented 2023-04-13 17:20:15 +02:00
Owner
Copy Link

Purpose

Instancer object could provide instances for its children objects, but we support only one instance object. Also removing/changing/adding of instancer object isn't working correctly.

Technical steps

  1. Restructured InstancerData:
    • now it could hold several ObjectData which are instances
    • restructured order of instancer and instance objects in RenderIndex.
  2. Refactoring:
    • improved logging in IdData children classes
    • splitted populate() and update_collection() in BlenderSceneDelegate to several functions for more flexibility.
  3. Improved/fixed:
    • object updates (transform, mesh update, remove) inside instancer
    • instancer updates (transform, update, remove).
### Purpose Instancer object could provide instances for its children objects, but we support only one instance object. Also removing/changing/adding of instancer object isn't working correctly. ### Technical steps 1. Restructured `InstancerData`: - now it could hold several `ObjectData` which are instances - restructured order of instancer and instance objects in `RenderIndex`. 2. Refactoring: - improved logging in `IdData` children classes - splitted `populate()` and `update_collection()` in `BlenderSceneDelegate` to several functions for more flexibility. 3. Improved/fixed: - object updates (transform, mesh update, remove) inside instancer - instancer updates (transform, update, remove).
Brian Savery (AMD) was assigned by Bogdan Nagirniak 2023-04-13 17:20:15 +02:00
Georgiy Markelov was assigned by Bogdan Nagirniak 2023-04-13 17:20:15 +02:00
Bogdan Nagirniak self-assigned this 2023-04-13 17:20:15 +02:00
Bogdan Nagirniak added 13 commits 2023-04-13 17:20:31 +02:00
f777cf428f Support several instancers on one object. 
Refactoring: moving ObjectData of base object to InstancerData.
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-04-13 17:20:40 +02:00
Bogdan Nagirniak requested review from Georgiy Markelov 2023-04-13 17:20:40 +02:00
Bogdan Nagirniak added 1 commit 2023-04-14 14:47:51 +02:00
Georgiy Markelov approved these changes 2023-04-14 17:56:03 +02:00
Georgiy Markelov left a comment
Collaborator
Copy Link

Tested. Works as expected.

Tested. Works as expected.
Brian Savery (AMD) approved these changes 2023-04-17 22:50:21 +02:00
Bogdan Nagirniak added 2 commits 2023-04-18 17:06:08 +02:00
Bogdan Nagirniak merged commit 40e3c2eb8c into hydra-render 2023-04-19 02:46:24 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Georgiy Markelov
Brian Savery (AMD)
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Brian Savery (AMD)
Bogdan Nagirniak
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#24
No description provided.
Delete Branch "BLEN-383"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?