BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Rename some functions #25

Merged
Bogdan Nagirniak merged 13 commits from BLEN-388 into hydra-render 2023-04-18 09:07:35 +02:00
Conversation 0 Commits 13 Files Changed 33 +1193 -1192
Georgiy Markelov commented 2023-04-13 17:32:24 +02:00
Collaborator
Copy Link

Purpose

Rename and reorder methods to match Blender's team requirements and code style.

### Purpose Rename and reorder methods to match Blender's team requirements and code style.
Georgiy Markelov added 5 commits 2023-04-13 17:32:35 +02:00
Brian Savery (AMD) was assigned by Georgiy Markelov 2023-04-13 17:32:45 +02:00
Georgiy Markelov self-assigned this 2023-04-13 17:32:46 +02:00
Bogdan Nagirniak was assigned by Georgiy Markelov 2023-04-13 17:32:46 +02:00
Georgiy Markelov requested review from Brian Savery (AMD) 2023-04-13 17:33:00 +02:00
Bogdan Nagirniak requested changes 2023-04-13 19:20:32 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Tested - works as expected.
Run `make format source\blender\render\hydra' for additional style fixes

Tested - works as expected. Run `make format source\blender\render\hydra' for additional style fixes
Georgiy Markelov added 1 commit 2023-04-13 20:36:07 +02:00
Georgiy Markelov requested review from Bogdan Nagirniak 2023-04-13 20:40:02 +02:00
Georgiy Markelov added 3 commits 2023-04-14 13:08:39 +02:00
Georgiy Markelov added 1 commit 2023-04-14 13:44:47 +02:00
Bogdan Nagirniak reviewed 2023-04-14 14:24:58 +02:00
source/blender/render/hydra/scene_delegate/blender_scene_delegate.h Outdated
@ -60,3 +57,1 @@
MaterialData *material_data(pxr::SdfPath const &id);
InstancerData *instancer_data(pxr::SdfPath const &id, bool base_prim = false);
InstancerData *instancer_data(Object *object);
ObjectData *get_object_data(pxr::SdfPath const &id);
Bogdan Nagirniak commented 2023-04-14 14:23:59 +02:00
Owner
Copy Link

is get_ prefix required by code style?

is `get_` prefix required by code style?
DagerD marked this conversation as resolved
source/blender/render/hydra/scene_delegate/blender_scene_delegate.h Outdated
@ -78,0 +69,4 @@
Depsgraph *depsgraph_ = nullptr;
bContext *context_ = nullptr;
View3D *view3d_ = nullptr;
Scene *scene_;
Bogdan Nagirniak commented 2023-04-14 14:20:30 +02:00
Owner
Copy Link

= nullptr

`= nullptr`
DagerD marked this conversation as resolved
Georgiy Markelov added 1 commit 2023-04-14 14:53:07 +02:00
Georgiy Markelov added 2 commits 2023-04-14 17:20:17 +02:00
Bogdan Nagirniak approved these changes 2023-04-14 17:59:48 +02:00
Brian Savery (AMD) approved these changes 2023-04-17 22:50:04 +02:00
Bogdan Nagirniak merged commit 7fa38c6b1e into hydra-render 2023-04-18 09:07:35 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Bogdan Nagirniak
Brian Savery (AMD)
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Brian Savery (AMD)
Bogdan Nagirniak
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#25
No description provided.
Delete Branch "BLEN-388"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?