BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Code improvements and fixes #26

Merged
Bogdan Nagirniak merged 8 commits from code_improvements_fixes into hydra-render 2023-04-21 07:48:50 +02:00
Conversation 0 Commits 8 Files Changed 17 +360 -380
Bogdan Nagirniak commented 2023-04-19 09:16:45 +02:00
Owner
Copy Link

Purpose

Made some code refactoring after implementing instances for better maintain code in future + added bug fixes.

Technical steps

  1. Refactor:

    • Moved prim_id() functions from IdData classes to BlenderSceneDelegate as more related
    • Moved to use ObjectData::transform as a field for better maintain it
    • Made some fields as public in BlenderSceneDelegate as logically more related and as they use in IdData classes. Made some fields in IdData as public. Removed some friends classes
    • Added const to some methods
    • Renamed some fields

  2. Bug fixes:

    • Fixed crash with Storm delegate after finish render
    • Fixed scene update after removing world object from scene
### Purpose Made some code refactoring after implementing instances for better maintain code in future + added bug fixes. ### Technical steps 1. Refactor: - Moved `prim_id()` functions from `IdData` classes to `BlenderSceneDelegate` as more related - Moved to use `ObjectData::transform` as a field for better maintain it - Made some fields as public in `BlenderSceneDelegate` as logically more related and as they use in `IdData` classes. Made some fields in `IdData` as public. Removed some friends classes - Added `const` to some methods - Renamed some fields 2. Bug fixes: - Fixed crash with Storm delegate after finish render - Fixed scene update after removing world object from scene
Bogdan Nagirniak self-assigned this 2023-04-19 09:16:45 +02:00
Brian Savery (AMD) was assigned by Bogdan Nagirniak 2023-04-19 09:16:45 +02:00
Georgiy Markelov was assigned by Bogdan Nagirniak 2023-04-19 09:16:45 +02:00
Bogdan Nagirniak added 8 commits 2023-04-19 09:16:56 +02:00 
Fixed crash with Storm delegate after closing viewport.
Moved calculation of material_resource to MaterialData::init().
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-04-19 09:17:09 +02:00
Bogdan Nagirniak requested review from Georgiy Markelov 2023-04-19 09:17:09 +02:00
Georgiy Markelov approved these changes 2023-04-19 11:08:32 +02:00
Georgiy Markelov left a comment
Collaborator
Copy Link

Tested. Works as intended.

Tested. Works as intended.
Brian Savery (AMD) approved these changes 2023-04-20 22:43:34 +02:00
Bogdan Nagirniak merged commit 4c48fbb63c into hydra-render 2023-04-21 07:48:50 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Georgiy Markelov
Brian Savery (AMD)
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Bogdan Nagirniak
Brian Savery (AMD)
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#26
No description provided.
Delete Branch "code_improvements_fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?