BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Move bpy_hydra.export_mtlx() exception handling to C code #28

Merged
Bogdan Nagirniak merged 9 commits from BLEN-392_pyerr_catch into hydra-render 2023-05-03 21:15:52 +02:00
Conversation 0 Commits 9 Files Changed 2 +29 -17
Bogdan Nagirniak commented 2023-04-20 18:38:43 +02:00
Owner
Copy Link

Purpose

Currently we catch all exceptions in bpy_hydra.export_mtlx(), because of memory issues.

Technical steps

  1. Removed except: and traceback.print_exc() from bpy_hydra.export_mtlx().
  2. Applied PyErr_Fetch() instead PyErr_Print() to correctly free exception data.
### Purpose Currently we catch all exceptions in `bpy_hydra.export_mtlx()`, because of memory issues. ### Technical steps 1. Removed `except:` and `traceback.print_exc()` from `bpy_hydra.export_mtlx()`. 2. Applied `PyErr_Fetch()` instead `PyErr_Print()` to correctly free exception data.
Bogdan Nagirniak self-assigned this 2023-04-20 18:38:43 +02:00
Brian Savery (AMD) was assigned by Bogdan Nagirniak 2023-04-20 18:38:43 +02:00
Georgiy Markelov was assigned by Bogdan Nagirniak 2023-04-20 18:38:43 +02:00
Bogdan Nagirniak added 4 commits 2023-04-20 18:38:53 +02:00
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-04-20 18:39:03 +02:00
Bogdan Nagirniak requested review from Georgiy Markelov 2023-04-20 18:39:03 +02:00
Bogdan Nagirniak added 4 commits 2023-04-21 15:25:22 +02:00
Georgiy Markelov approved these changes 2023-04-21 17:55:01 +02:00
Georgiy Markelov left a comment
Collaborator
Copy Link

Tested. Works good.

Tested. Works good.
Bogdan Nagirniak added 1 commit 2023-05-03 13:34:27 +02:00
Brian Savery (AMD) approved these changes 2023-05-03 18:50:01 +02:00
Bogdan Nagirniak merged commit b9cd5b597e into hydra-render 2023-05-03 21:15:52 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Georgiy Markelov
Brian Savery (AMD)
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Bogdan Nagirniak
Brian Savery (AMD)
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#28
No description provided.
Delete Branch "BLEN-392_pyerr_catch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?