BogdanNagirniak
/
blender
forked from blender/blender
0
0
Fork 3
Code Pull Requests Activity

Add IBL support #29

Merged
Bogdan Nagirniak merged 5 commits from BLEN-385 into hydra-render 2023-04-27 09:25:11 +02:00
Conversation 0 Commits 5 Files Changed 14 +117 -109
Georgiy Markelov commented 2023-04-24 13:44:23 +02:00
Collaborator
Copy Link

Purpose

Add support for ".exr" image extention for DomeLight

Technical steps

  1. Refactored:
    • moved cache_image_file() from utils.cc to scene_delegate/image.cc
    • moved gf_matrix_from_transform() from utils.cc to scene_delegate/object.cc
    • removed utils.cc as not needed.
  2. Implemented more correct image caching.
  3. Adjusted passing image for DomeLight.
  4. Added copying hioOiio folder.
### Purpose Add support for ".exr" image extention for DomeLight ### Technical steps 1. Refactored: - moved `cache_image_file()` from `utils.cc` to `scene_delegate/image.cc` - moved `gf_matrix_from_transform()` from `utils.cc` to `scene_delegate/object.cc` - removed `utils.cc` as not needed. 2. Implemented more correct image caching. 3. Adjusted passing image for DomeLight. 4. Added copying hioOiio folder.
Georgiy Markelov added 1 commit 2023-04-24 13:44:36 +02:00
Brian Savery (AMD) was assigned by Georgiy Markelov 2023-04-24 13:50:05 +02:00
Georgiy Markelov self-assigned this 2023-04-24 13:50:05 +02:00
Bogdan Nagirniak was assigned by Georgiy Markelov 2023-04-24 13:50:06 +02:00
Georgiy Markelov requested review from Brian Savery (AMD) 2023-04-24 13:50:09 +02:00
Bogdan Nagirniak added 1 commit 2023-04-25 19:18:13 +02:00
38135e6662 Refactored: moved utils.h|.cc -> scene_delegate/image.h|.cc. 
Improved working with cache_or_get_image_file()
Bogdan Nagirniak changed title from add IBL support for RPRHydra to Add IBL support 2023-04-26 08:44:25 +02:00
Bogdan Nagirniak added 1 commit 2023-04-26 16:28:01 +02:00
Bogdan Nagirniak approved these changes 2023-04-26 16:33:56 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Made refactoring + implemented more correct image caching

Made refactoring + implemented more correct image caching
Bogdan Nagirniak added 1 commit 2023-04-26 16:38:28 +02:00
Bogdan Nagirniak added 1 commit 2023-04-26 17:29:38 +02:00
Brian Savery (AMD) approved these changes 2023-04-27 00:46:33 +02:00
Bogdan Nagirniak merged commit 9bb6dbf82a into hydra-render 2023-04-27 09:25:11 +02:00
Bogdan Nagirniak referenced this issue from a commit 2023-04-27 09:25:11 +02:00
Add IBL support
Sign in to join this conversation.
Reviewers
No reviewers
Bogdan Nagirniak
Brian Savery (AMD)
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Brian Savery (AMD)
Bogdan Nagirniak
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#29
No description provided.
Delete Branch "BLEN-385"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?