BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Implement instancing for light objects #35

Merged
Bogdan Nagirniak merged 18 commits from BLEN-395 into hydra-render 2023-05-04 15:12:27 +02:00
Conversation 0 Commits 18 Files Changed 14 +300 -161
Bogdan Nagirniak commented 2023-05-03 14:50:00 +02:00
Owner
Copy Link

Purpose

Instancing of light objects isn't working yet. It differs from mesh instancing, because they light instances has to be created as separate light prims for HdRenderIndex.

Technical steps

  1. Separated MeshInstance and LightInstance in Instancer class.
  2. Implemented Instancer to create light instances as separate prims for HdRenderIndex.
  3. Fixed light update.

Notes

This PR includes #33. It has to be updated after merging #33

### Purpose Instancing of light objects isn't working yet. It differs from mesh instancing, because they light instances has to be created as separate light prims for HdRenderIndex. ### Technical steps 1. Separated `MeshInstance` and `LightInstance` in `Instancer` class. 2. Implemented `Instancer` to create light instances as separate prims for HdRenderIndex. 3. Fixed light update. ### Notes This PR includes #33. It has to be updated after merging #33
Bogdan Nagirniak self-assigned this 2023-05-03 14:50:00 +02:00
Brian Savery (AMD) was assigned by Bogdan Nagirniak 2023-05-03 14:50:00 +02:00
Georgiy Markelov was assigned by Bogdan Nagirniak 2023-05-03 14:50:00 +02:00
Bogdan Nagirniak added 15 commits 2023-05-03 14:50:13 +02:00 
Fixed transform for instance object.
Added check of parent object change.
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-05-03 14:50:28 +02:00
Bogdan Nagirniak requested review from Georgiy Markelov 2023-05-03 14:50:28 +02:00
Brian Savery (AMD) approved these changes 2023-05-03 18:53:23 +02:00
Bogdan Nagirniak added 1 commit 2023-05-03 21:31:59 +02:00
Bogdan Nagirniak added 1 commit 2023-05-04 08:43:15 +02:00 
Removed MaterialData::create(), WorldData::create(), InstancerData::create() as not needed.
Bogdan Nagirniak added 1 commit 2023-05-04 09:42:13 +02:00
Georgiy Markelov approved these changes 2023-05-04 13:34:27 +02:00
Georgiy Markelov left a comment
Collaborator
Copy Link

Tested. Works fine.

Tested. Works fine.
Bogdan Nagirniak merged commit c53ee9af58 into hydra-render 2023-05-04 15:12:27 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Georgiy Markelov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Bogdan Nagirniak
Brian Savery (AMD)
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#35
No description provided.
Delete Branch "BLEN-395"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?