BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Recreate PreviewEngine when render_delegate_name is changed #36

Merged
Bogdan Nagirniak merged 6 commits from BLEN-404 into hydra-render 2023-05-05 14:49:30 +02:00
Conversation 0 Commits 6 Files Changed 5 +21 -11
Georgiy Markelov commented 2023-05-04 10:33:17 +02:00
Collaborator
Copy Link

Purpose

Recreate PreviewEngine when render_delegate_name is changed.

Technical steps

Added comparison of render_delegate_name and PreviewEngine re-creation on PreviewEngine::update

### Purpose Recreate `PreviewEngine` when `render_delegate_name` is changed. ### Technical steps Added comparison of `render_delegate_name` and `PreviewEngine` re-creation on `PreviewEngine::update`
Georgiy Markelov added 2 commits 2023-05-04 10:33:27 +02:00
Brian Savery (AMD) was assigned by Georgiy Markelov 2023-05-04 10:33:52 +02:00
Georgiy Markelov self-assigned this 2023-05-04 10:33:52 +02:00
Bogdan Nagirniak was assigned by Georgiy Markelov 2023-05-04 10:33:52 +02:00
Georgiy Markelov requested review from Brian Savery (AMD) 2023-05-04 10:33:57 +02:00
Bogdan Nagirniak requested changes 2023-05-04 17:33:17 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Discussed offline: there are some bugs with crash related to PreviewEngine which could be fixed in this PR.

Discussed offline: there are some bugs with crash related to PreviewEngine which could be fixed in this PR.
Brian Savery (AMD) approved these changes 2023-05-05 01:58:30 +02:00
Georgiy Markelov added 2 commits 2023-05-05 13:04:53 +02:00
Georgiy Markelov requested review from Bogdan Nagirniak 2023-05-05 13:04:56 +02:00
Georgiy Markelov added 1 commit 2023-05-05 13:07:20 +02:00
Bogdan Nagirniak added 1 commit 2023-05-05 14:29:48 +02:00
Bogdan Nagirniak approved these changes 2023-05-05 14:30:29 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Added small code improvements. Tested - works ok

Added small code improvements. Tested - works ok
Bogdan Nagirniak merged commit a95359896d into hydra-render 2023-05-05 14:49:30 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Brian Savery (AMD)
Bogdan Nagirniak
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#36
No description provided.
Delete Branch "BLEN-404"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?