BogdanNagirniak
/
blender
forked from blender/blender
0
0
Fork 3
Code Pull Requests Activity

Fix rendering of Car Demo scene #37

Merged
Bogdan Nagirniak merged 2 commits from Vasyl-Pidhirskyi/blender_bn:BLEN-399 into hydra-render 2023-05-05 20:55:52 +02:00
Conversation 0 Commits 2 Files Changed 2 +4 -12
Vasyl Pidhirskyi commented 2023-05-05 13:42:28 +02:00
Collaborator
Copy Link

Purpose

Fix rendering of Car Demo scene.

Technical steps

Improved support for instancers type of EMPTY object.
Adjusted condition for update_instancers and available_objects.

### Purpose Fix rendering of Car Demo scene. ### Technical steps Improved support for instancers type of EMPTY object. Adjusted condition for `update_instancers` and `available_objects`.
Vasyl Pidhirskyi added 1 commit 2023-05-05 13:42:37 +02:00
Vasyl Pidhirskyi requested review from Brian Savery (AMD) 2023-05-05 13:43:12 +02:00
Vasyl Pidhirskyi requested review from Georgiy Markelov 2023-05-05 13:43:12 +02:00
Brian Savery (AMD) was assigned by Vasyl Pidhirskyi 2023-05-05 13:45:30 +02:00
Georgiy Markelov was assigned by Vasyl Pidhirskyi 2023-05-05 13:45:30 +02:00
Bogdan Nagirniak was assigned by Vasyl Pidhirskyi 2023-05-05 13:45:30 +02:00
Bogdan Nagirniak requested changes 2023-05-05 14:35:53 +02:00
source/blender/render/hydra/scene_delegate/blender_scene_delegate.cc Outdated
@ -436,3 +436,2 @@
if (!ObjectData::is_supported(object)) {
continue;
if (ObjectData::is_supported(object)) {
Bogdan Nagirniak commented 2023-05-05 14:34:51 +02:00
Owner
Copy Link

This check is already in update_objects(), so here it can be just removed

This check is already in `update_objects()`, so here it can be just removed
source/blender/render/hydra/scene_delegate/blender_scene_delegate.cc Outdated
@ -548,3 +542,1 @@
if (!object_data(object_prim_id(object))) {
update_objects(object);
if (ObjectData::is_supported(object)) {
Bogdan Nagirniak commented 2023-05-05 14:35:36 +02:00
Owner
Copy Link

Same here, just remove this if (...)

Same here, just remove this `if (...)`
Vasyl Pidhirskyi added 1 commit 2023-05-05 15:07:54 +02:00
Bogdan Nagirniak approved these changes 2023-05-05 16:16:14 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Tested - works good

Tested - works good
Brian Savery (AMD) approved these changes 2023-05-05 20:35:46 +02:00
Bogdan Nagirniak merged commit 1dd88bd713 into hydra-render 2023-05-05 20:55:52 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Georgiy Markelov
Bogdan Nagirniak
Brian Savery (AMD)
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Brian Savery (AMD)
Bogdan Nagirniak
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#37
No description provided.
Delete Branch "Vasyl-Pidhirskyi/blender_bn:BLEN-399"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?