BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Implement GetDoubleSided and GetCullStyle for BlenderSceneDelegate #38

Merged
Bogdan Nagirniak merged 3 commits from BLEN-408 into hydra-render 2023-05-10 14:03:18 +02:00
Conversation 0 Commits 3 Files Changed 8 +63 -4
Bogdan Nagirniak commented 2023-05-05 17:54:30 +02:00
Owner
Copy Link

Purpose

GetDoubleSided and GetCullStyle has to be implemented for BlenderSceneDelegate. It is especially important for HdStorm.

Technical steps

  1. double_sided option is material property, not mesh, therefore it was translated from MaterialData to MeshData.
  2. Implemented set of DirtyDoubleSided for mesh when it was changed for material.
### Purpose GetDoubleSided and GetCullStyle has to be implemented for BlenderSceneDelegate. It is especially important for HdStorm. ### Technical steps 1. `double_sided` option is material property, not mesh, therefore it was translated from MaterialData to MeshData. 2. Implemented set of `DirtyDoubleSided` for mesh when it was changed for material.
Bogdan Nagirniak self-assigned this 2023-05-05 17:54:30 +02:00
Brian Savery (AMD) was assigned by Bogdan Nagirniak 2023-05-05 17:54:30 +02:00
Georgiy Markelov was assigned by Bogdan Nagirniak 2023-05-05 17:54:30 +02:00
Vasyl Pidhirskyi was assigned by Bogdan Nagirniak 2023-05-05 17:54:30 +02:00
Bogdan Nagirniak added 2 commits 2023-05-05 17:54:44 +02:00 
Initial implementation
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-05-05 17:54:52 +02:00
Bogdan Nagirniak requested review from Georgiy Markelov 2023-05-05 17:54:53 +02:00
Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-05-05 17:54:53 +02:00
Brian Savery (AMD) approved these changes 2023-05-05 20:36:12 +02:00
Bogdan Nagirniak added 1 commit 2023-05-05 21:11:07 +02:00
Georgiy Markelov approved these changes 2023-05-10 12:54:17 +02:00
Georgiy Markelov left a comment
Collaborator
Copy Link

Tested. Works fine.

Tested. Works fine.
Bogdan Nagirniak merged commit b918617073 into hydra-render 2023-05-10 14:03:18 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Vasyl Pidhirskyi
Brian Savery (AMD)
Georgiy Markelov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Bogdan Nagirniak
Brian Savery (AMD)
Vasyl Pidhirskyi
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#38
No description provided.
Delete Branch "BLEN-408"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?