BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Fixing build on MacOS #39

Merged
Bogdan Nagirniak merged 1 commits from macos-build-fix into hydra-render 2023-05-11 09:12:04 +02:00
Conversation 1 Commits 1 Files Changed 6 +19 -10
Bogdan Nagirniak commented 2023-05-09 13:13:14 +02:00
Owner
Copy Link

Purpose

There are compiling bugs on MacOS.

Technical steps

  1. Adjusted ID_LOG macros.
  2. Added several includes.
  3. Code improvements: removed some comments, added namespace blender::render::hydra to mtlx_hydra_adapter.mtlx.
### Purpose There are compiling bugs on MacOS. ### Technical steps 1. Adjusted ID_LOG macros. 2. Added several includes. 3. Code improvements: removed some comments, added `namespace blender::render::hydra` to `mtlx_hydra_adapter.mtlx`.
Bogdan Nagirniak self-assigned this 2023-05-09 13:13:14 +02:00
Brian Savery (AMD) was assigned by Bogdan Nagirniak 2023-05-09 13:13:14 +02:00
Georgiy Markelov was assigned by Bogdan Nagirniak 2023-05-09 13:13:14 +02:00
Vasyl Pidhirskyi was assigned by Bogdan Nagirniak 2023-05-09 13:13:14 +02:00
Bogdan Nagirniak added 1 commit 2023-05-09 13:13:35 +02:00
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-05-09 13:14:14 +02:00
Bogdan Nagirniak requested review from Georgiy Markelov 2023-05-09 13:14:15 +02:00
Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-05-09 13:14:15 +02:00
Brian Savery (AMD) approved these changes 2023-05-10 00:43:40 +02:00
Georgiy Markelov approved these changes 2023-05-10 10:03:59 +02:00
Matt McLin commented 2023-05-10 23:02:57 +02:00
Collaborator
Copy Link

I checked out this commit and confirmed this builds OK for me on macOS 13 + Xcode 14.

I checked out this commit and confirmed this builds OK for me on macOS 13 + Xcode 14.
Bogdan Nagirniak merged commit 796398e8cc into hydra-render 2023-05-11 09:12:04 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Vasyl Pidhirskyi
Brian Savery (AMD)
Georgiy Markelov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Bogdan Nagirniak
Brian Savery (AMD)
Vasyl Pidhirskyi
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#39
No description provided.
Delete Branch "macos-build-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?