BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Move to use blender::Map container instead std::unordered_map #47

Merged
Bogdan Nagirniak merged 17 commits from Vasyl-Pidhirskyi/blender_bn:BLEN-418 into hydra-render 2023-06-02 12:02:46 +02:00
Conversation 0 Commits 17 Files Changed 12 +8 -10
2 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 445e628bf3 - Show all commits

3
source/blender/render/hydra/scene_delegate/blender_scene_delegate.cc
View File

@ -386,8 +386,7 @@ void BlenderSceneDelegate::update_instancers(Object *object)
return;
}
instancers_.add_new(id, std::make_unique<InstancerData>(this, object, id));
i_data = instancer_data(id);
i_data = instancers_.lookup_or_add(id, std::make_unique<InstancerData>(this, object, id)).get();
Vasyl-Pidhirskyi marked this conversation as resolved Outdated
Georgiy Markelov commented 2023-05-30 13:01:44 +02:00
Outdated
Review
Copy Link

seems like here should be add_new.

seems like here should be `add_new`.
Bogdan Nagirniak commented 2023-05-31 16:33:17 +02:00
Outdated
Review
Copy Link

use lookup_or_add_default

use `lookup_or_add_default`
Vasyl Pidhirskyi commented 2023-06-01 15:46:24 +02:00
Outdated
Review
Copy Link

implemented via lookup_or_add

implemented via `lookup_or_add`
i_data->init();
i_data->insert();
}

11
source/blender/render/hydra/scene_delegate/mesh.cc
View File

@ -301,16 +301,15 @@ void MeshData::write_materials()
m.mat_data = nullptr;
continue;
}
pxr::SdfPath p_id = scene_delegate_->material_prim_id(mat);
m.mat_data = scene_delegate_->material_data(p_id);
if (!m.mat_data) {
scene_delegate_->materials_.add_new(
p_id, std::make_unique<MaterialData>(scene_delegate_, mat, p_id));
m.mat_data = scene_delegate_->material_data(p_id);
m.mat_data = scene_delegate_->materials_
.lookup_or_add(p_id,
Vasyl-Pidhirskyi marked this conversation as resolved Outdated
Georgiy Markelov commented 2023-05-30 13:21:18 +02:00
Outdated
Review
Copy Link

seems like here should be add_new.

seems like here should be `add_new`.
Bogdan Nagirniak commented 2023-05-31 16:46:36 +02:00
Outdated
Review
Copy Link

lookup_or_add_default

`lookup_or_add_default`
Vasyl Pidhirskyi commented 2023-06-01 15:46:15 +02:00
Outdated
Review
Copy Link

implemented via lookup_or_add

implemented via `lookup_or_add`
std::make_unique<MaterialData>(scene_delegate_, mat, p_id))
.get();
m.mat_data->init();
m.mat_data->insert();
}
}
}
} // namespace blender::render::hydra