BogdanNagirniak
/
blender
forked from blender/blender
0
0
Fork 3
Code Pull Requests Activity

Change log severity for better maintability #50

Merged
Bogdan Nagirniak merged 6 commits from Vasyl-Pidhirskyi/blender_bn:BLEN-422 into hydra-render 2023-06-05 19:46:21 +02:00
Conversation 0 Commits 6 Files Changed 10 +47 -41
Vasyl Pidhirskyi commented 2023-06-01 16:09:51 +02:00
Collaborator
Copy Link

Purpose

Severity for LOG_RENDER_HYDRA_SCENE:

0: add/remove/update objects in BlenderSceneDelegate
1: add/remove/update objects in IdData classes
2: visibility, instances
3: getters

Technical steps

Adjusted levels.

### Purpose Severity for LOG_RENDER_HYDRA_SCENE: 0: add/remove/update objects in BlenderSceneDelegate 1: add/remove/update objects in IdData classes 2: visibility, instances 3: getters ### Technical steps Adjusted levels.
Vasyl Pidhirskyi added 1 commit 2023-06-01 16:10:02 +02:00
85a3f6b1ec Initial commit 
Adjusted levels
Vasyl Pidhirskyi requested review from Brian Savery (AMD) 2023-06-01 16:10:14 +02:00
Vasyl Pidhirskyi requested review from Georgiy Markelov 2023-06-01 16:10:14 +02:00
Brian Savery (AMD) was assigned by Vasyl Pidhirskyi 2023-06-01 16:10:23 +02:00
Georgiy Markelov was assigned by Vasyl Pidhirskyi 2023-06-01 16:10:23 +02:00
Bogdan Nagirniak was assigned by Vasyl Pidhirskyi 2023-06-01 16:10:24 +02:00
Vasyl Pidhirskyi self-assigned this 2023-06-01 16:10:24 +02:00
Georgiy Markelov approved these changes 2023-06-01 18:41:35 +02:00
Georgiy Markelov left a comment
Collaborator
Copy Link

one comment

one comment
source/blender/render/hydra/scene_delegate/instancer.cc Outdated
@ -133,6 +133,7 @@ bool InstancerData::update_visibility()
}
}
}
ID_LOG(2, "");
Georgiy Markelov commented 2023-06-01 18:38:52 +02:00
Collaborator
Copy Link

Should it be moved inside if (ret) {?

Should it be moved inside `if (ret) {`?
Vasyl-Pidhirskyi marked this conversation as resolved
Brian Savery (AMD) approved these changes 2023-06-01 21:20:03 +02:00
Vasyl Pidhirskyi added 1 commit 2023-06-02 09:58:31 +02:00
Bogdan Nagirniak requested changes 2023-06-02 13:06:34 +02:00
source/blender/render/hydra/python.cc Outdated
@ -123,3 +123,3 @@
}
CLOG_INFO(LOG_RENDER_HYDRA, 2, "Engine %016llx %s", engine, engine_type);
CLOG_INFO(LOG_RENDER_HYDRA, 0, "Engine %016llx %s", engine, engine_type);
Bogdan Nagirniak commented 2023-06-02 12:41:30 +02:00
Owner
Copy Link

create and free engine -> 1

create and free engine -> 1
Vasyl-Pidhirskyi marked this conversation as resolved
source/blender/render/hydra/python.cc Outdated
@ -174,3 +174,3 @@
Py_END_ALLOW_THREADS;
CLOG_INFO(LOG_RENDER_HYDRA, 2, "Engine %016llx", engine);
CLOG_INFO(LOG_RENDER_HYDRA, 0, "Engine %016llx", engine);
Bogdan Nagirniak commented 2023-06-02 12:44:47 +02:00
Owner
Copy Link

sync, render -> 2

sync, render -> 2
Vasyl-Pidhirskyi marked this conversation as resolved
source/blender/render/hydra/python.cc Outdated
@ -194,3 +194,3 @@
Py_END_ALLOW_THREADS;
CLOG_INFO(LOG_RENDER_HYDRA, 3, "Engine %016llx", engine);
CLOG_INFO(LOG_RENDER_HYDRA, 0, "Engine %016llx", engine);
Bogdan Nagirniak commented 2023-06-02 12:44:55 +02:00
Owner
Copy Link

3

3
Vasyl-Pidhirskyi marked this conversation as resolved
source/blender/render/hydra/scene_delegate/blender_scene_delegate.cc Outdated
@ -512,3 +512,3 @@
{
CLOG_INFO(LOG_RENDER_HYDRA_SCENE,
2,
0,
Bogdan Nagirniak commented 2023-06-02 12:56:27 +02:00
Owner
Copy Link

visibility -> 2

visibility -> 2
Vasyl-Pidhirskyi marked this conversation as resolved
source/blender/render/hydra/scene_delegate/image.cc Outdated
@ -48,3 +48,3 @@
BKE_image_save_options_free(&opts);
CLOG_INFO(LOG_RENDER_HYDRA_SCENE, 2, "%s -> %s", image->id.name, file_path.c_str());
CLOG_INFO(LOG_RENDER_HYDRA_SCENE, 3, "%s -> %s", image->id.name, file_path.c_str());
Bogdan Nagirniak commented 2023-06-02 12:58:00 +02:00
Owner
Copy Link

Move to if (BKE_image_save(...)), severity 1

Move to `if (BKE_image_save(...))`, severity 1
Vasyl-Pidhirskyi marked this conversation as resolved
source/blender/render/hydra/scene_delegate/image.cc Outdated
@ -72,3 +72,3 @@
}
CLOG_INFO(LOG_RENDER_HYDRA_SCENE, 2, "%s -> %s", image->id.name, file_path.c_str());
CLOG_INFO(LOG_RENDER_HYDRA_SCENE, 3, "%s -> %s", image->id.name, file_path.c_str());
Bogdan Nagirniak commented 2023-06-02 12:59:01 +02:00
Owner
Copy Link

1

1
Vasyl-Pidhirskyi marked this conversation as resolved
source/blender/render/hydra/scene_delegate/instancer.cc Outdated
@ -116,6 +116,7 @@ bool InstancerData::update_visibility()
bool ret = visible != prev_visible;
if (ret) {
ID_LOG(2, "");
Bogdan Nagirniak commented 2023-06-02 13:04:31 +02:00
Owner
Copy Link

InstancerData init, remove, update/update_visibility -> 1

InstancerData init, remove, update/update_visibility -> 1
Vasyl-Pidhirskyi marked this conversation as resolved
Vasyl Pidhirskyi added 2 commits 2023-06-05 12:09:16 +02:00
Vasyl Pidhirskyi added 2 commits 2023-06-05 12:18:28 +02:00
Vasyl Pidhirskyi requested review from Bogdan Nagirniak 2023-06-05 12:18:58 +02:00
Bogdan Nagirniak approved these changes 2023-06-05 19:45:39 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Tested - works good

Tested - works good
Bogdan Nagirniak merged commit 1c62eeb25c into hydra-render 2023-06-05 19:46:21 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Georgiy Markelov
Brian Savery (AMD)
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Brian Savery (AMD)
Bogdan Nagirniak
Vasyl Pidhirskyi
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#50
No description provided.
Delete Branch "Vasyl-Pidhirskyi/blender_bn:BLEN-422"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?