Change log severity for better maintability #50

Merged
Bogdan Nagirniak merged 6 commits from Vasyl-Pidhirskyi/blender_bn:BLEN-422 into hydra-render 2023-06-05 19:46:21 +02:00
Collaborator

Purpose

Severity for LOG_RENDER_HYDRA_SCENE:

0: add/remove/update objects in BlenderSceneDelegate
1: add/remove/update objects in IdData classes
2: visibility, instances
3: getters

Technical steps

Adjusted levels.

### Purpose Severity for LOG_RENDER_HYDRA_SCENE: 0: add/remove/update objects in BlenderSceneDelegate 1: add/remove/update objects in IdData classes 2: visibility, instances 3: getters ### Technical steps Adjusted levels.
Vasyl Pidhirskyi added 1 commit 2023-06-01 16:10:02 +02:00
Adjusted levels
Vasyl Pidhirskyi requested review from Brian Savery (AMD) 2023-06-01 16:10:14 +02:00
Vasyl Pidhirskyi requested review from Georgiy Markelov 2023-06-01 16:10:14 +02:00
Brian Savery (AMD) was assigned by Vasyl Pidhirskyi 2023-06-01 16:10:23 +02:00
Georgiy Markelov was assigned by Vasyl Pidhirskyi 2023-06-01 16:10:23 +02:00
Bogdan Nagirniak was assigned by Vasyl Pidhirskyi 2023-06-01 16:10:24 +02:00
Vasyl Pidhirskyi self-assigned this 2023-06-01 16:10:24 +02:00
Georgiy Markelov approved these changes 2023-06-01 18:41:35 +02:00
Georgiy Markelov left a comment
Collaborator

one comment

one comment
@ -133,6 +133,7 @@ bool InstancerData::update_visibility()
}
}
}
ID_LOG(2, "");
Collaborator

Should it be moved inside if (ret) {?

Should it be moved inside `if (ret) {`?
Vasyl-Pidhirskyi marked this conversation as resolved
Brian Savery (AMD) approved these changes 2023-06-01 21:20:03 +02:00
Vasyl Pidhirskyi added 1 commit 2023-06-02 09:58:31 +02:00
Bogdan Nagirniak requested changes 2023-06-02 13:06:34 +02:00
@ -123,3 +123,3 @@
}
CLOG_INFO(LOG_RENDER_HYDRA, 2, "Engine %016llx %s", engine, engine_type);
CLOG_INFO(LOG_RENDER_HYDRA, 0, "Engine %016llx %s", engine, engine_type);

create and free engine -> 1

create and free engine -> 1
Vasyl-Pidhirskyi marked this conversation as resolved
@ -174,3 +174,3 @@
Py_END_ALLOW_THREADS;
CLOG_INFO(LOG_RENDER_HYDRA, 2, "Engine %016llx", engine);
CLOG_INFO(LOG_RENDER_HYDRA, 0, "Engine %016llx", engine);

sync, render -> 2

sync, render -> 2
Vasyl-Pidhirskyi marked this conversation as resolved
@ -194,3 +194,3 @@
Py_END_ALLOW_THREADS;
CLOG_INFO(LOG_RENDER_HYDRA, 3, "Engine %016llx", engine);
CLOG_INFO(LOG_RENDER_HYDRA, 0, "Engine %016llx", engine);

3

3
Vasyl-Pidhirskyi marked this conversation as resolved
@ -512,3 +512,3 @@
{
CLOG_INFO(LOG_RENDER_HYDRA_SCENE,
2,
0,

visibility -> 2

visibility -> 2
Vasyl-Pidhirskyi marked this conversation as resolved
@ -48,3 +48,3 @@
BKE_image_save_options_free(&opts);
CLOG_INFO(LOG_RENDER_HYDRA_SCENE, 2, "%s -> %s", image->id.name, file_path.c_str());
CLOG_INFO(LOG_RENDER_HYDRA_SCENE, 3, "%s -> %s", image->id.name, file_path.c_str());

Move to if (BKE_image_save(...)), severity 1

Move to `if (BKE_image_save(...))`, severity 1
Vasyl-Pidhirskyi marked this conversation as resolved
@ -72,3 +72,3 @@
}
CLOG_INFO(LOG_RENDER_HYDRA_SCENE, 2, "%s -> %s", image->id.name, file_path.c_str());
CLOG_INFO(LOG_RENDER_HYDRA_SCENE, 3, "%s -> %s", image->id.name, file_path.c_str());

1

1
Vasyl-Pidhirskyi marked this conversation as resolved
@ -116,6 +116,7 @@ bool InstancerData::update_visibility()
bool ret = visible != prev_visible;
if (ret) {
ID_LOG(2, "");

InstancerData init, remove, update/update_visibility -> 1

InstancerData init, remove, update/update_visibility -> 1
Vasyl-Pidhirskyi marked this conversation as resolved
Vasyl Pidhirskyi added 2 commits 2023-06-05 12:09:16 +02:00
Vasyl Pidhirskyi added 2 commits 2023-06-05 12:18:28 +02:00
Vasyl Pidhirskyi requested review from Bogdan Nagirniak 2023-06-05 12:18:58 +02:00
Bogdan Nagirniak approved these changes 2023-06-05 19:45:39 +02:00
Bogdan Nagirniak left a comment
Owner

Tested - works good

Tested - works good
Bogdan Nagirniak merged commit 1c62eeb25c into hydra-render 2023-06-05 19:46:21 +02:00
Sign in to join this conversation.
No Label
No Milestone
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#50
No description provided.