BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Change log severity for better maintability #50

Merged
Bogdan Nagirniak merged 6 commits from Vasyl-Pidhirskyi/blender_bn:BLEN-422 into hydra-render 2023-06-05 19:46:21 +02:00
Conversation 0 Commits 6 Files Changed 10 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit fc95eb94cc - Show all commits

2
source/blender/render/hydra/scene_delegate/instancer.cc
View File

@ -116,6 +116,7 @@ bool InstancerData::update_visibility()
bool ret = visible != prev_visible; bool ret = visible != prev_visible;
if (ret) { if (ret) {
ID_LOG(2, "");
Vasyl-Pidhirskyi marked this conversation as resolved Outdated
Bogdan Nagirniak commented 2023-06-02 13:04:31 +02:00
Outdated
Review
Copy Link

InstancerData init, remove, update/update_visibility -> 1

InstancerData init, remove, update/update_visibility -> 1
auto &change_tracker = scene_delegate_->GetRenderIndex().GetChangeTracker(); auto &change_tracker = scene_delegate_->GetRenderIndex().GetChangeTracker();
change_tracker.MarkInstancerDirty(prim_id, pxr::HdChangeTracker::DirtyVisibility); change_tracker.MarkInstancerDirty(prim_id, pxr::HdChangeTracker::DirtyVisibility);
for (auto &it : mesh_instances_) { for (auto &it : mesh_instances_) {
@ -133,7 +134,6 @@ bool InstancerData::update_visibility()
} }
} }
} }
Vasyl-Pidhirskyi marked this conversation as resolved Outdated
Georgiy Markelov commented 2023-06-01 18:38:52 +02:00
Outdated
Review
Copy Link

Should it be moved inside if (ret) {?

Should it be moved inside `if (ret) {`?
ID_LOG(2, "");
return ret; return ret;
} }