BogdanNagirniak
/
blender
forked from blender/blender
0
0
Fork 3
Code Pull Requests Activity

Fix review comments #51

Merged
Bogdan Nagirniak merged 15 commits from BLEN-430 into hydra-render 2023-06-08 18:10:55 +02:00
Conversation 0 Commits 15 Files Changed 13 +63 -136
Georgiy Markelov commented 2023-06-06 14:15:08 +02:00
Collaborator
Copy Link

Purpose

Refactoring: fix Brecht's review comments

Technical steps

  • Removed unnecessary code
  • Fixed widths, uvs and material for curves
  • Code improvements
  • Removed bypass to avoid BKE_object_to_mesh
  • Removed pxr::PlugRegistry::GetInstance().RegisterPlugins, init_func and get_render_plugins_func
### Purpose Refactoring: fix Brecht's review comments ### Technical steps * Removed unnecessary code * Fixed widths, uvs and material for curves * Code improvements * Removed bypass to avoid `BKE_object_to_mesh` * Removed `pxr::PlugRegistry::GetInstance().RegisterPlugins`, `init_func` and `get_render_plugins_func`
Georgiy Markelov added 8 commits 2023-06-06 14:15:27 +02:00
Brian Savery (AMD) was assigned by Georgiy Markelov 2023-06-06 14:15:36 +02:00
Georgiy Markelov self-assigned this 2023-06-06 14:15:36 +02:00
Bogdan Nagirniak was assigned by Georgiy Markelov 2023-06-06 14:15:37 +02:00
Vasyl Pidhirskyi was assigned by Georgiy Markelov 2023-06-06 14:15:37 +02:00
Georgiy Markelov requested review from Brian Savery (AMD) 2023-06-06 14:18:10 +02:00
Georgiy Markelov requested review from Vasyl Pidhirskyi 2023-06-06 14:18:11 +02:00
Bogdan Nagirniak requested changes 2023-06-06 14:37:59 +02:00
source/blender/render/hydra/scene_delegate/curves.cc Outdated
@ -190,3 +186,3 @@
Material *mat = nullptr;
if (BKE_object_material_count_eval(object) > 0) {
mat = BKE_object_material_get_eval(object, object->actcol);
mat = BKE_object_material_get_eval(object, 0);
Bogdan Nagirniak commented 2023-06-06 14:37:33 +02:00
Owner
Copy Link

Add comment here about using first material and TODO about support multimaterial

Add comment here about using first material and TODO about support multimaterial
DagerD marked this conversation as resolved
source/blender/render/hydra/scene_delegate/image.cc
@ -26,3 +26,1 @@
snprintf(file_name, 32, "img_%016llx.hdr", (uintptr_t)image);
BLI_path_join(file_path.data(),
file_path.capacity(),
snprintf(file_name, sizeof(file_name), "img_%016llx.hdr", (uintptr_t)image);
Bogdan Nagirniak commented 2023-06-06 14:35:05 +02:00
Owner
Copy Link

add same sizeof(...) to other places with snprintf()

add same `sizeof(...)` to other places with `snprintf()`
DagerD marked this conversation as resolved
source/blender/render/hydra/scene_delegate/material.cc Outdated
@ -112,3 +112,3 @@
std::string path;
if (!PyErr_Occurred()) {
if (!PyErr_Occurred() && PyUnicode_Check(result)) {
Bogdan Nagirniak commented 2023-06-06 14:32:23 +02:00
Owner
Copy Link

Move PyUnicode_Check(result) into block below

Move `PyUnicode_Check(result)` into block below
DagerD marked this conversation as resolved
Georgiy Markelov added 1 commit 2023-06-06 14:58:55 +02:00
Georgiy Markelov added 1 commit 2023-06-06 15:00:43 +02:00
Brian Savery (AMD) approved these changes 2023-06-06 23:39:48 +02:00
Georgiy Markelov added 1 commit 2023-06-07 16:20:48 +02:00
Bogdan Nagirniak changed title from Refactoring: fix Brecht's review comments to Fix review comments 2023-06-07 16:29:29 +02:00
Georgiy Markelov added 2 commits 2023-06-08 10:36:34 +02:00
Georgiy Markelov added 2 commits 2023-06-08 10:48:15 +02:00
Bogdan Nagirniak approved these changes 2023-06-08 18:10:05 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Tested - works good

Tested - works good
Bogdan Nagirniak merged commit 6e0c502076 into hydra-render 2023-06-08 18:10:55 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Vasyl Pidhirskyi
Brian Savery (AMD)
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Brian Savery (AMD)
Bogdan Nagirniak
Vasyl Pidhirskyi
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#51
No description provided.
Delete Branch "BLEN-430"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?