BogdanNagirniak
/
blender
forked from blender/blender
0
0
Fork 3
Code Pull Requests Activity

Fix DomeLight warning in console for Storm delegate. #55

Merged
Bogdan Nagirniak merged 5 commits from BLEN-432 into hydra-render 2023-06-13 19:13:36 +02:00
Conversation 0 Commits 5 Files Changed 4 +65 -9
Bogdan Nagirniak commented 2023-06-10 19:58:04 +02:00
Owner
Copy Link

Purpose

Storm delegate produces warning if not texture in DomeLight: Warning: in _GetResolvedDomeLightEnvironmentFilePath at line 320 of C:\db\build\S\VS1564R\build\usd\src\external_usd\pxr\imaging\hdSt\simpleLightingShader.cpp -- Dome light has no texture asset path.

Technical steps

Implemented cache_image_color() to image.cc.
Added pxr::HdLightTokens->textureFile to WorldData with colored texture if only color is available.

### Purpose Storm delegate produces warning if not texture in DomeLight: `Warning: in _GetResolvedDomeLightEnvironmentFilePath at line 320 of C:\db\build\S\VS1564R\build\usd\src\external_usd\pxr\imaging\hdSt\simpleLightingShader.cpp -- Dome light has no texture asset path.` ### Technical steps Implemented cache_image_color() to image.cc. Added pxr::HdLightTokens->textureFile to WorldData with colored texture if only color is available.
Bogdan Nagirniak self-assigned this 2023-06-10 19:58:04 +02:00
Brian Savery (AMD) was assigned by Bogdan Nagirniak 2023-06-10 19:58:04 +02:00
Georgiy Markelov was assigned by Bogdan Nagirniak 2023-06-10 19:58:04 +02:00
Vasyl Pidhirskyi was assigned by Bogdan Nagirniak 2023-06-10 19:58:04 +02:00
Bogdan Nagirniak added 1 commit 2023-06-10 19:58:23 +02:00
8ae44f9aaa Fix DomeLight warning in console for Storm delegate. 
Implemented cache_image_color() to image.cc.
Added pxr::HdLightTokens->textureFile to WorldData with colored texture if only color is available.
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-06-10 19:58:31 +02:00
Bogdan Nagirniak requested review from Georgiy Markelov 2023-06-10 19:58:31 +02:00
Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-06-10 19:58:31 +02:00
Brian Savery (AMD) approved these changes 2023-06-13 00:10:55 +02:00
Bogdan Nagirniak added 2 commits 2023-06-13 04:39:40 +02:00
Georgiy Markelov approved these changes 2023-06-13 12:50:27 +02:00
Bogdan Nagirniak added 2 commits 2023-06-13 19:12:32 +02:00
Bogdan Nagirniak merged commit 70844a9a16 into hydra-render 2023-06-13 19:13:36 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Vasyl Pidhirskyi
Brian Savery (AMD)
Georgiy Markelov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Bogdan Nagirniak
Brian Savery (AMD)
Vasyl Pidhirskyi
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#55
No description provided.
Delete Branch "BLEN-432"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?