BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Export volumes #58

Merged
Bogdan Nagirniak merged 10 commits from BLEN-384 into hydra-render 2023-07-04 09:57:33 +02:00
Conversation 0 Commits 10 Files Changed 9 +264 -8
Georgiy Markelov commented 2023-06-26 18:31:26 +02:00
Collaborator
Copy Link

Purpose

Add support for volumes export

Technical steps

Added new class VolumeData

Note for reviewers

Use HdRPR with https://github.com/bnagirniak/RPRHydraRenderBlenderAddon/pull/21

### Purpose Add support for volumes export ### Technical steps Added new class `VolumeData` ### Note for reviewers Use HdRPR with https://github.com/bnagirniak/RPRHydraRenderBlenderAddon/pull/21
Georgiy Markelov self-assigned this 2023-06-26 18:31:26 +02:00
Brian Savery (AMD) was assigned by Georgiy Markelov 2023-06-26 18:31:26 +02:00
Vasyl Pidhirskyi was assigned by Georgiy Markelov 2023-06-26 18:31:26 +02:00
Bogdan Nagirniak was assigned by Georgiy Markelov 2023-06-26 18:31:26 +02:00
Georgiy Markelov added 8 commits 2023-06-26 18:31:48 +02:00 
Code improvements;
Brian Savery (AMD) approved these changes 2023-06-26 18:43:10 +02:00
Georgiy Markelov requested review from Vasyl Pidhirskyi 2023-06-26 18:44:31 +02:00
Vasyl Pidhirskyi reviewed 2023-06-30 09:32:08 +02:00
Vasyl Pidhirskyi left a comment
Collaborator
Copy Link

discussed offline

discussed offline
Bogdan Nagirniak requested changes 2023-07-03 12:28:27 +02:00
source/blender/render/hydra/scene_delegate/volume.cc Outdated
@ -0,0 +57,4 @@
{
/* NOTE: Is it possible to manipulate a list of fields in Blender?
* Also something can happen to file.
* Probably we need to store a field list in class. */
Bogdan Nagirniak commented 2023-07-03 12:26:10 +02:00
Owner
Copy Link

Yes, move volume_field_descriptors to private field VolumeData::field_descriptors_

Yes, move volume_field_descriptors to private field `VolumeData::field_descriptors_`
source/blender/render/hydra/scene_delegate/volume.cc
@ -0,0 +120,4 @@
return ret;
}
pxr::HdVolumeFieldDescriptorVector VolumeData::volume_field_descriptors() const
Bogdan Nagirniak commented 2023-07-03 12:26:44 +02:00
Owner
Copy Link

rename to field_descriptors

rename to `field_descriptors`
Georgiy Markelov added 1 commit 2023-07-03 16:09:20 +02:00
Bogdan Nagirniak approved these changes 2023-07-03 17:46:56 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Tested - works ok for Storm delegate. RPR delegate requires transform fix on HdRPR side.
Set log level 1 in VolumeData::remove()

Tested - works ok for Storm delegate. RPR delegate requires transform fix on HdRPR side. Set log level 1 in `VolumeData::remove()`
source/blender/render/hydra/scene_delegate/volume.cc Outdated
@ -0,0 +71,4 @@
void VolumeData::remove()
{
for (auto &desc : field_descriptors_) {
CLOG_INFO(LOG_RENDER_HYDRA_SCENE, 2, "%s", desc.fieldId.GetText());
Bogdan Nagirniak commented 2023-07-03 17:41:18 +02:00
Owner
Copy Link

log level 1 for remove

log level 1 for remove
Georgiy Markelov added 1 commit 2023-07-04 09:07:54 +02:00
Bogdan Nagirniak merged commit c0dd92c641 into hydra-render 2023-07-04 09:57:33 +02:00
Bogdan Nagirniak referenced this issue from a commit 2023-07-04 09:57:34 +02:00
Export volumes
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Vasyl Pidhirskyi
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Brian Savery (AMD)
Vasyl Pidhirskyi
Bogdan Nagirniak
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#58
No description provided.
Delete Branch "BLEN-384"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?