BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Fix crash when hydra render plugin isn't loaded #60

Merged
Bogdan Nagirniak merged 1 commits from BLEN-443 into hydra-render 2023-07-04 10:22:36 +02:00
Conversation 0 Commits 1 Files Changed 3 +28 -14
Bogdan Nagirniak commented 2023-07-02 18:20:07 +02:00
Owner
Copy Link

Purpose

Render engine crashes when hydra render delegate isn't loaded.

Technical steps

Added throw to Engine creation when render_delegate_ wasn't created.
Added corresponding error logging in python.cc.
Adjusted bpy_hydra.py.

### Purpose Render engine crashes when hydra render delegate isn't loaded. ### Technical steps Added `throw` to `Engine` creation when `render_delegate_ ` wasn't created. Added corresponding error logging in `python.cc`. Adjusted `bpy_hydra.py`.
Bogdan Nagirniak self-assigned this 2023-07-02 18:20:07 +02:00
Brian Savery (AMD) was assigned by Bogdan Nagirniak 2023-07-02 18:20:07 +02:00
Georgiy Markelov was assigned by Bogdan Nagirniak 2023-07-02 18:20:07 +02:00
Vasyl Pidhirskyi was assigned by Bogdan Nagirniak 2023-07-02 18:20:07 +02:00
Bogdan Nagirniak added 1 commit 2023-07-02 18:20:24 +02:00
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-07-02 18:20:32 +02:00
Bogdan Nagirniak requested review from Georgiy Markelov 2023-07-02 18:20:32 +02:00
Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-07-02 18:20:33 +02:00
Brian Savery (AMD) approved these changes 2023-07-04 00:16:56 +02:00
Georgiy Markelov approved these changes 2023-07-04 10:21:38 +02:00
Georgiy Markelov left a comment
Collaborator
Copy Link

Works fine

Works fine
Bogdan Nagirniak merged commit 0a07bd1424 into hydra-render 2023-07-04 10:22:36 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Vasyl Pidhirskyi
Brian Savery (AMD)
Georgiy Markelov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Bogdan Nagirniak
Brian Savery (AMD)
Vasyl Pidhirskyi
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#60
No description provided.
Delete Branch "BLEN-443"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?