BogdanNagirniak
/
blender
forked from blender/blender
0
0
Fork 3
Code Pull Requests Activity

Export volumes from object modifier (quick effect) #62

Merged
Bogdan Nagirniak merged 28 commits from BLEN-448 into hydra-render 2023-07-20 23:49:25 +02:00
Conversation 1 Commits 28 Files Changed 8 +180 -9
Georgiy Markelov commented 2023-07-07 17:23:43 +02:00
Collaborator
Copy Link

Purpose

Add export volumes from object modifier (quick effect)

Technical steps

Added new class VolumeModifierData
Added processing of Volume quick effect

### Purpose Add export volumes from object modifier (quick effect) ### Technical steps Added new class `VolumeModifierData` Added processing of Volume quick effect
Georgiy Markelov self-assigned this 2023-07-07 17:23:43 +02:00
Bogdan Nagirniak was assigned by Georgiy Markelov 2023-07-07 17:23:43 +02:00
Georgiy Markelov added 4 commits 2023-07-07 17:24:06 +02:00
Georgiy Markelov added 2 commits 2023-07-11 15:51:40 +02:00
Georgiy Markelov added 3 commits 2023-07-11 17:06:21 +02:00
69345afd33 make format 
removed unused imports
Georgiy Markelov added 1 commit 2023-07-11 17:06:45 +02:00
Georgiy Markelov added 1 commit 2023-07-11 17:07:25 +02:00
Georgiy Markelov added 1 commit 2023-07-11 17:10:26 +02:00
Georgiy Markelov changed title from WIP: Export volumes from object modifier (quick effect) to Export volumes from object modifier (quick effect) 2023-07-11 17:10:48 +02:00
Brian Savery (AMD) was assigned by Georgiy Markelov 2023-07-11 17:10:57 +02:00
Georgiy Markelov requested review from Brian Savery (AMD) 2023-07-11 17:11:04 +02:00
Georgiy Markelov requested review from Vasyl Pidhirskyi 2023-07-11 17:11:05 +02:00
Bogdan Nagirniak requested changes 2023-07-11 17:37:21 +02:00
source/blender/render/hydra/scene_delegate/object.cc Outdated
@ -26,2 +26,4 @@
std::unique_ptr<ObjectData> data;
if (VolumeData::is_volume_modifier(object)) {
return std::make_unique<VolumeData>(scene_delegate, object, prim_id);
Bogdan Nagirniak commented 2023-07-11 17:24:40 +02:00
Owner
Copy Link

Propose to create class VolumeModifierData::public VolumeData and separate logic in these two classes

Propose to create `class VolumeModifierData::public VolumeData` and separate logic in these two classes
DagerD marked this conversation as resolved
Georgiy Markelov added 1 commit 2023-07-12 11:55:04 +02:00
Georgiy Markelov added 2 commits 2023-07-12 12:20:01 +02:00
Georgiy Markelov added 2 commits 2023-07-12 13:30:46 +02:00
Georgiy Markelov added 1 commit 2023-07-13 10:55:01 +02:00
Bogdan Nagirniak added 5 commits 2023-07-14 16:18:13 +02:00
Bogdan Nagirniak added 1 commit 2023-07-14 16:26:57 +02:00
Bogdan Nagirniak approved these changes 2023-07-14 16:28:26 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Added fixes to VolumeModifierData::write_transform() added some fixes to VolumeData, improved logging.

Added fixes to `VolumeModifierData::write_transform()` added some fixes to `VolumeData`, improved logging.
Bogdan Nagirniak added 2 commits 2023-07-14 20:12:22 +02:00
Georgiy Markelov commented 2023-07-18 15:24:32 +02:00
Author
Collaborator
Copy Link

Approved.

Approved.
Vasyl Pidhirskyi approved these changes 2023-07-19 14:48:49 +02:00
Vasyl Pidhirskyi left a comment
Collaborator
Copy Link

Known issue related to transforms in HdRpr.

Known issue related to transforms in HdRpr.
Brian Savery (AMD) approved these changes 2023-07-20 21:01:05 +02:00
Bogdan Nagirniak added 2 commits 2023-07-20 23:47:42 +02:00
Bogdan Nagirniak merged commit 288c9d6e04 into hydra-render 2023-07-20 23:49:25 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Bogdan Nagirniak
Vasyl Pidhirskyi
Brian Savery (AMD)
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Bogdan Nagirniak
Brian Savery (AMD)
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#62
No description provided.
Delete Branch "BLEN-448"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?