BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Make DomeLight visible for Storm delegate #68

Merged
Bogdan Nagirniak merged 5 commits from Vasyl-Pidhirskyi/blender_bn:BLEN-460 into hydra-render 2023-07-20 22:35:48 +02:00
Conversation 0 Commits 5 Files Changed 9 +107 -98
Vasyl Pidhirskyi commented 2023-07-18 15:55:16 +02:00
Collaborator
Copy Link

Purpose

Make world color and texture visible for Storm delegate.

Technical steps

  • Implemented LightTasksDelegate.
  • Updates CMakeLists.txt with light_tasks_delegate.h, light_tasks_delegate.cc.
  • Appended HdTaskSharedPtrVector with light_tasks_delegate_.
### Purpose Make world color and texture visible for Storm delegate. ### Technical steps - Implemented LightTasksDelegate. - Updates CMakeLists.txt with light_tasks_delegate.h, light_tasks_delegate.cc. - Appended HdTaskSharedPtrVector with light_tasks_delegate_.
Vasyl Pidhirskyi added 1 commit 2023-07-18 15:55:34 +02:00 
Updates CMakeLists.txt with skydome_task_delegate.h, skydome_task_delegate.cc.
Appended HdTaskSharedPtrVector with skydome_task_delegate_.
Vasyl Pidhirskyi requested review from Brian Savery (AMD) 2023-07-18 15:56:03 +02:00
Vasyl Pidhirskyi requested review from Georgiy Markelov 2023-07-18 15:56:03 +02:00
Brian Savery (AMD) was assigned by Vasyl Pidhirskyi 2023-07-18 15:56:12 +02:00
Georgiy Markelov was assigned by Vasyl Pidhirskyi 2023-07-18 15:56:13 +02:00
Bogdan Nagirniak was assigned by Vasyl Pidhirskyi 2023-07-18 15:56:13 +02:00
Vasyl Pidhirskyi self-assigned this 2023-07-18 15:56:18 +02:00
Bogdan Nagirniak requested changes 2023-07-18 17:36:16 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Works good, but would like to improve code by combining SkydomeTaskDelegate and SimpleLightTaskDelegate to one class LightTaskDelegate

Works good, but would like to improve code by combining `SkydomeTaskDelegate` and `SimpleLightTaskDelegate` to one `class LightTaskDelegate`
source/blender/render/hydra/skydome_task_delegate.h Outdated
@ -0,0 +8,4 @@
namespace blender::render::hydra {
class SkydomeTaskDelegate : public pxr::HdSceneDelegate {
Bogdan Nagirniak commented 2023-07-18 17:35:17 +02:00
Owner
Copy Link

Combine SkydomeTaskDelegate and SimpleLightTaskDelegate to one class LightTaskDelegate

Combine `SkydomeTaskDelegate` and `SimpleLightTaskDelegate` to one `class LightTaskDelegate`
Vasyl-Pidhirskyi marked this conversation as resolved
Vasyl Pidhirskyi added 1 commit 2023-07-20 10:43:52 +02:00
Vasyl Pidhirskyi added 1 commit 2023-07-20 10:47:37 +02:00
Vasyl Pidhirskyi requested review from Bogdan Nagirniak 2023-07-20 10:59:18 +02:00
Vasyl Pidhirskyi added 1 commit 2023-07-20 11:40:58 +02:00 
Removed workaround.
Vasyl Pidhirskyi added 1 commit 2023-07-20 12:00:05 +02:00
Bogdan Nagirniak approved these changes 2023-07-20 12:33:44 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Tested - works ok.

Tested - works ok.
Brian Savery (AMD) approved these changes 2023-07-20 21:00:24 +02:00
Bogdan Nagirniak merged commit 9c3dcacd9c into hydra-render 2023-07-20 22:35:48 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Georgiy Markelov
Bogdan Nagirniak
Brian Savery (AMD)
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Brian Savery (AMD)
Georgiy Markelov
Bogdan Nagirniak
Vasyl Pidhirskyi
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#68
No description provided.
Delete Branch "Vasyl-Pidhirskyi/blender_bn:BLEN-460"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?