BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

PreviewEngine for Storm delegate #69

Merged
Bogdan Nagirniak merged 1 commits from Vasyl-Pidhirskyi/blender_bn:BLEN-462 into hydra-render 2023-07-21 11:28:14 +02:00
Conversation 0 Commits 1 Files Changed 3 +87 -1
Vasyl Pidhirskyi commented 2023-07-20 16:44:48 +02:00
Collaborator
Copy Link

Purpose

Make available Strom delegate to utilize for material preview.

Technical steps

  • Implemented PreviewEngineGPU::render. Similar to FinalEngineGPU::render.
  • Adjusted python.cc to use PreviewEngineGPU.

Notes for reviewers

Should be reviewed with the pull request BogdanNagirniak/blender-addons#20

### Purpose Make available Strom delegate to utilize for material preview. ### Technical steps - Implemented PreviewEngineGPU::render. Similar to FinalEngineGPU::render. - Adjusted python.cc to use PreviewEngineGPU. ### Notes for reviewers Should be reviewed with the pull request https://projects.blender.org/BogdanNagirniak/blender-addons/pulls/20
Vasyl Pidhirskyi added 1 commit 2023-07-20 16:45:07 +02:00 
Adjusted python.cc to use PreviewEngineGPU.
Vasyl Pidhirskyi requested review from Brian Savery (AMD) 2023-07-20 16:50:48 +02:00
Vasyl Pidhirskyi requested review from Georgiy Markelov 2023-07-20 16:50:48 +02:00
Brian Savery (AMD) was assigned by Vasyl Pidhirskyi 2023-07-20 16:51:00 +02:00
Georgiy Markelov was assigned by Vasyl Pidhirskyi 2023-07-20 16:51:00 +02:00
Bogdan Nagirniak was assigned by Vasyl Pidhirskyi 2023-07-20 16:51:00 +02:00
Vasyl Pidhirskyi self-assigned this 2023-07-20 16:51:01 +02:00
Brian Savery (AMD) approved these changes 2023-07-20 20:59:51 +02:00
Bogdan Nagirniak approved these changes 2023-07-21 11:27:21 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Tested - works good

Tested - works good
Bogdan Nagirniak merged commit 47e030e465 into hydra-render 2023-07-21 11:28:14 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Georgiy Markelov
Brian Savery (AMD)
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Brian Savery (AMD)
Georgiy Markelov
Bogdan Nagirniak
Vasyl Pidhirskyi
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#69
No description provided.
Delete Branch "Vasyl-Pidhirskyi/blender_bn:BLEN-462"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?