BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Hydra tasks refactor #73

Merged
Bogdan Nagirniak merged 8 commits from hydra-tasks-refactor into hydra-render 2023-07-25 22:13:33 +02:00
Conversation 0 Commits 8 Files Changed 12 +427 -495
Bogdan Nagirniak commented 2023-07-23 22:36:23 +02:00
Owner
Copy Link

Purpose

Code for RenderTaskDelegate is obsolete + working with separate framebuffer for GPU engines instead of aov is hard to maintain.
This is preparation for supporting more AOVs and GL context with core profile mode.

Technical steps

  1. Moved working with GPUTexture and GPUFramebuffer to RenderTaskDelegate. Now it is working the same as AOVs. Added class GPURenderTaskDelegate : public RenderTaskDelegate. Improved structure of class RenderTaskDelegate.
  2. Removed FinalEngineGPU, PreviewEngineGPU as not needed, as forking with render framebuffer moved to RenderTaskDelegate. Simplified PreviewEngine.
  3. Additionally improved structure of LightTasksDelegate for easier to maintain.
  4. Adjusted FinalEngine and ViewportEngine.
### Purpose Code for `RenderTaskDelegate` is obsolete + working with separate framebuffer for GPU engines instead of aov is hard to maintain. This is preparation for supporting more AOVs and GL context with core profile mode. ### Technical steps 1. Moved working with `GPUTexture` and `GPUFramebuffer` to `RenderTaskDelegate`. Now it is working the same as AOVs. Added `class GPURenderTaskDelegate : public RenderTaskDelegate`. Improved structure of `class RenderTaskDelegate`. 2. Removed `FinalEngineGPU`, `PreviewEngineGPU` as not needed, as forking with render framebuffer moved to `RenderTaskDelegate`. Simplified `PreviewEngine`. 3. Additionally improved structure of `LightTasksDelegate` for easier to maintain. 4. Adjusted `FinalEngine` and `ViewportEngine`.
Bogdan Nagirniak added 8 commits 2023-07-23 22:36:34 +02:00 
Simplified PreviewEngine
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-07-23 22:36:52 +02:00
Bogdan Nagirniak requested review from Georgiy Markelov 2023-07-23 22:36:52 +02:00
Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-07-23 22:36:53 +02:00
Vasyl Pidhirskyi approved these changes 2023-07-24 11:29:11 +02:00
Vasyl Pidhirskyi left a comment
Collaborator
Copy Link

Works well.

Works well.
Georgiy Markelov approved these changes 2023-07-24 17:01:10 +02:00
Georgiy Markelov left a comment
Collaborator
Copy Link

Tested. Works Fine. @BrianSavery please review, I need this PR for other task.

Tested. Works Fine. @BrianSavery please review, I need this PR for other task.
Brian Savery (AMD) approved these changes 2023-07-25 21:03:07 +02:00
Bogdan Nagirniak merged commit d4789b2d9a into hydra-render 2023-07-25 22:13:33 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Vasyl Pidhirskyi
Georgiy Markelov
Brian Savery (AMD)
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#73
No description provided.
Delete Branch "hydra-tasks-refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?