BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Support instancing for other objects: curves and volumes #74

Merged
Bogdan Nagirniak merged 4 commits from BLEN-449 into hydra-render 2023-07-26 10:27:51 +02:00
Conversation 2 Commits 4 Files Changed 7 +121 -137
Bogdan Nagirniak commented 2023-07-24 19:42:09 +02:00
Owner
Copy Link

Purpose

Curves and volumes are supported objects but not working as instances.

Technical steps

  1. Changed InstancerData::LightInstance to InstancerData::NonmeshInstance which supports all other object types except mesh.
  2. Adjusted update_nonmesh_instance to support all object types.
  3. Made code adjustments and renamings.
### Purpose Curves and volumes are supported objects but not working as instances. ### Technical steps 1. Changed `InstancerData::LightInstance` to `InstancerData::NonmeshInstance` which supports all other object types except mesh. 2. Adjusted `update_nonmesh_instance` to support all object types. 3. Made code adjustments and renamings.
Bogdan Nagirniak added 3 commits 2023-07-24 19:42:33 +02:00 
Initial implementation.
Other code improvements.
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-07-24 19:42:42 +02:00
Bogdan Nagirniak requested review from Georgiy Markelov 2023-07-24 19:42:43 +02:00
Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-07-24 19:42:43 +02:00
Georgiy Markelov requested changes 2023-07-25 16:42:02 +02:00
Georgiy Markelov left a comment
Collaborator
Copy Link

HdRPR with instanced curves gives following warning:

Warning (secondary thread): in Sync at line 170 of C:\GPUOpen\RPRHydraRenderBlenderAddon\RadeonProRenderUSD\pxr\imaging\plugin\hdRpr\basisCurves.cpp -- [/scene/Instancer/O_00000252C16DB908/NM_00000002] Unsupported uv interpolation type

HdRPR with instanced curves gives following warning: `Warning (secondary thread): in Sync at line 170 of C:\GPUOpen\RPRHydraRenderBlenderAddon\RadeonProRenderUSD\pxr\imaging\plugin\hdRpr\basisCurves.cpp -- [/scene/Instancer/O_00000252C16DB908/NM_00000002] Unsupported uv interpolation type`
Brian Savery (AMD) approved these changes 2023-07-25 21:02:20 +02:00
Bogdan Nagirniak added 1 commit 2023-07-25 22:32:52 +02:00
Bogdan Nagirniak commented 2023-07-25 22:35:10 +02:00
Author
Owner
Copy Link

HdRPR with instanced curves gives following warning:

Warning (secondary thread): in Sync at line 170 of C:\GPUOpen\RPRHydraRenderBlenderAddon\RadeonProRenderUSD\pxr\imaging\plugin\hdRpr\basisCurves.cpp -- [/scene/Instancer/O_00000252C16DB908/NM_00000002] Unsupported uv interpolation type

Seems this bug relates to CurvesData, not to this PR. I have this warning when curves object is not instance
Warning (secondary thread): in Sync at line 170 of C:\GPUOpen\RPRHydraRenderBlenderAddon\RadeonProRenderUSD\pxr\imaging\plugin\hdRpr\basisCurves.cpp -- [/scene/O_000002BFF2A01D08] Unsupported uv interpolation type

> HdRPR with instanced curves gives following warning: > > `Warning (secondary thread): in Sync at line 170 of C:\GPUOpen\RPRHydraRenderBlenderAddon\RadeonProRenderUSD\pxr\imaging\plugin\hdRpr\basisCurves.cpp -- [/scene/Instancer/O_00000252C16DB908/NM_00000002] Unsupported uv interpolation type` Seems this bug relates to CurvesData, not to this PR. I have this warning when curves object is not instance `Warning (secondary thread): in Sync at line 170 of C:\GPUOpen\RPRHydraRenderBlenderAddon\RadeonProRenderUSD\pxr\imaging\plugin\hdRpr\basisCurves.cpp -- [/scene/O_000002BFF2A01D08] Unsupported uv interpolation type`
Georgiy Markelov commented 2023-07-26 09:55:54 +02:00
Collaborator
Copy Link

Rechecked - You are right.

Rechecked - You are right.
Georgiy Markelov approved these changes 2023-07-26 09:56:04 +02:00
Bogdan Nagirniak merged commit 5e91a47f10 into hydra-render 2023-07-26 10:27:51 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Vasyl Pidhirskyi
Brian Savery (AMD)
Georgiy Markelov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#74
No description provided.
Delete Branch "BLEN-449"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?