BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Render fixes after refactoring #79

Merged
Bogdan Nagirniak merged 5 commits from hydra-refactor-fixes into hydra-render 2023-07-29 11:45:06 +02:00
Conversation 1 Commits 5 Files Changed 5 +64 -39
Bogdan Nagirniak commented 2023-07-28 09:09:43 +02:00
Owner
Copy Link

Purpose

After refactoring PRs there are render issues such as crash with RPR delegate in viewport.

Technical steps

  1. Moved binding of framebuffer and VAO to GPURenderTaskDelegate and use it in Viewport render.
  2. Made more correct viewport render for Storm delegate by rendering it to separate framebuffer.

Notes

Expect to fix MacOS issues here in new commits.

### Purpose After refactoring PRs there are render issues such as crash with RPR delegate in viewport. ### Technical steps 1. Moved binding of framebuffer and VAO to `GPURenderTaskDelegate` and use it in Viewport render. 2. Made more correct viewport render for Storm delegate by rendering it to separate framebuffer. ### Notes Expect to fix MacOS issues here in new commits.
Bogdan Nagirniak added 3 commits 2023-07-28 09:10:05 +02:00
Bogdan Nagirniak requested review from Brecht Van Lommel 2023-07-28 09:10:18 +02:00
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-07-28 09:10:19 +02:00
Bogdan Nagirniak requested review from Georgiy Markelov 2023-07-28 09:10:19 +02:00
Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-07-28 09:10:19 +02:00
Brecht Van Lommel commented 2023-07-28 13:55:43 +02:00
Collaborator
Copy Link

These changes make Hydra Storm in the 3D viewport much slower here, testing on Linux + NVIDIA. Seems to be reading back the texture to CPU memory on every redraw.
profile.png

These changes make Hydra Storm in the 3D viewport much slower here, testing on Linux + NVIDIA. Seems to be reading back the texture to CPU memory on every redraw. ![profile.png](/attachments/b9038ce9-afc2-4818-8656-edba51f78026)
profile.png
340 KiB
Bogdan Nagirniak added 1 commit 2023-07-28 15:42:22 +02:00
Brecht Van Lommel approved these changes 2023-07-28 18:24:43 +02:00
Brecht Van Lommel left a comment
Collaborator
Copy Link

Works fine for me now.

Works fine for me now.
source/blender/render/hydra/render_task_delegate.cc Outdated
@ -267,3 +277,2 @@
GPU_framebuffer_free(framebuffer_);
GPU_texture_free(tex_color_);
GPU_texture_free(tex_depth_);
}
Brecht Van Lommel commented 2023-07-28 18:24:02 +02:00
Collaborator
Copy Link

Can you set VAO_ to 0 and framebuffer_ to null?

Not strictly required, but more future proof.

Can you set VAO_ to 0 and framebuffer_ to null? Not strictly required, but more future proof.
Bogdan Nagirniak added 1 commit 2023-07-29 11:35:28 +02:00
Bogdan Nagirniak merged commit eca3438772 into hydra-render 2023-07-29 11:45:06 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Georgiy Markelov
Vasyl Pidhirskyi
Brecht Van Lommel
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#79
No description provided.
Delete Branch "hydra-refactor-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?