BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

BLEN-343: Create PreviewEngine #8

Merged
Bogdan Nagirniak merged 5 commits from BLEN-343 into hydra-render 2023-03-03 14:55:28 +01:00
Conversation 0 Commits 5 Files Changed 25 +170 -40
Georgiy Markelov commented 2023-03-02 13:14:51 +01:00
Collaborator
Copy Link

Added preview engine.

changed pxr::HdSceneDelegate to BlenderSceneDelegate
added enum Engine::EngineType
added Engine::EngineType to BlenderSceneDelegate

Use with https://github.com/bnagirniak/RPRHydraRenderBlenderAddon/pull/8

Added preview engine. changed `pxr::HdSceneDelegate` to `BlenderSceneDelegate` added `enum Engine::EngineType` added `Engine::EngineType` to `BlenderSceneDelegate` Use with https://github.com/bnagirniak/RPRHydraRenderBlenderAddon/pull/8
Georgiy Markelov added 2 commits 2023-03-02 13:15:00 +01:00
Bogdan Nagirniak requested changes 2023-03-02 15:04:10 +01:00
release/scripts/modules/hydra.py
@ -47,3 +47,3 @@
_hydra.engine_sync(self.engine_ptr, depsgraph.as_pointer(), bpy.context.as_pointer(), delegate_settings)
_hydra.engine_render(self.engine_ptr, depsgraph.as_pointer())
_hydra.engine_render(self.engine_ptr, depsgraph.as_pointer(), engine_type)
Bogdan Nagirniak commented 2023-03-02 14:58:07 +01:00
Owner
Copy Link

revert this

revert this
source/blender/render/hydra/previewEngine.h
@ -0,0 +7,4 @@
namespace blender::render::hydra {
class PreviewEngine : public Engine {
Bogdan Nagirniak commented 2023-03-02 15:00:19 +01:00
Owner
Copy Link

Maybe inherit from FinalEngine?

Maybe inherit from FinalEngine?
DagerD marked this conversation as resolved
Georgiy Markelov added 1 commit 2023-03-02 15:46:59 +01:00
Georgiy Markelov added 1 commit 2023-03-02 16:49:51 +01:00 
added enum Engine::EngineType
added Engine::EngineType to BlenderSceneDelegate
Bogdan Nagirniak requested changes 2023-03-03 09:39:04 +01:00
source/blender/render/hydra/engine.h
@ -24,2 +24,4 @@
class Engine {
public:
enum class EngineType {
Bogdan Nagirniak commented 2023-03-03 09:35:47 +01:00
Owner
Copy Link

move to BlenderSceneDelegate class

move to BlenderSceneDelegate class
DagerD marked this conversation as resolved
source/blender/render/hydra/previewEngine.cc
@ -0,0 +29,4 @@
void PreviewEngine::render(BL::Depsgraph &b_depsgraph)
{
if (!is_synced) {
Bogdan Nagirniak commented 2023-03-03 09:38:58 +01:00
Owner
Copy Link

check if (!sceneDelegate) instead is_synced

check `if (!sceneDelegate)` instead is_synced
DagerD marked this conversation as resolved
Georgiy Markelov added 1 commit 2023-03-03 10:48:00 +01:00
Bogdan Nagirniak approved these changes 2023-03-03 14:54:38 +01:00
Bogdan Nagirniak merged commit 722b766d20 into hydra-render 2023-03-03 14:55:28 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#8
No description provided.
Delete Branch "BLEN-343"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?