BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Hydra code cleanup #81

Merged
Bogdan Nagirniak merged 7 commits from hydra-code-cleanup into hydra-render 2023-08-01 21:35:28 +02:00
Conversation 0 Commits 7 Files Changed 20 +151 -145
Bogdan Nagirniak commented 2023-07-29 16:56:19 +02:00
Owner
Copy Link

Purpose

After code refactor in #75 there is good to adjust logging + do code polishing and improvement.

Technical steps

  1. Renamed logger LOG_RENDER_HYDRA_SCENE -> LOG_HYDRA_SCENE as "hydra.scene".
  2. Renamed logger LOG_RENDER_HYDRA -> LOG_HYDRA_RENDER as "hydra.render".
  3. Simplified Engine classes by adding depsgraph_, context_ and scene_ to class fields. Unified structure of Engine classes.
  4. Moved AOV tokens map to FinalEngine as more related.
  5. Made other code cleanups and improvements.
### Purpose After code refactor in #75 there is good to adjust logging + do code polishing and improvement. ### Technical steps 1. Renamed logger `LOG_RENDER_HYDRA_SCENE -> LOG_HYDRA_SCENE` as "hydra.scene". 2. Renamed logger `LOG_RENDER_HYDRA -> LOG_HYDRA_RENDER` as "hydra.render". 3. Simplified `Engine` classes by adding `depsgraph_`, `context_` and `scene_` to class fields. Unified structure of `Engine` classes. 4. Moved AOV tokens map to `FinalEngine` as more related. 5. Made other code cleanups and improvements.
Bogdan Nagirniak added 7 commits 2023-07-29 16:56:35 +02:00
Bogdan Nagirniak requested review from Brecht Van Lommel 2023-07-29 16:56:57 +02:00
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-07-29 16:56:57 +02:00
Bogdan Nagirniak requested review from Georgiy Markelov 2023-07-29 16:56:57 +02:00
Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-07-29 16:56:58 +02:00
Georgiy Markelov approved these changes 2023-07-31 12:34:23 +02:00
Georgiy Markelov left a comment
Collaborator
Copy Link

Tested, works fine.

Tested, works fine.
Brecht Van Lommel approved these changes 2023-08-01 15:16:32 +02:00
Brian Savery (AMD) approved these changes 2023-08-01 20:13:47 +02:00
Bogdan Nagirniak merged commit debaa39dfe into hydra-render 2023-08-01 21:35:28 +02:00
Bogdan Nagirniak referenced this issue from a commit 2023-08-01 21:35:29 +02:00
Hydra code cleanup
Sign in to join this conversation.
Reviewers
No reviewers
Vasyl Pidhirskyi
Georgiy Markelov
Brecht Van Lommel
Brian Savery (AMD)
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#81
No description provided.
Delete Branch "hydra-code-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?