Bogdan Nagirniak BogdanNagirniak
  • Joined on 2023-02-13
Bogdan Nagirniak pushed to hydra-render at BogdanNagirniak/blender 2023-03-03 16:07:36 +01:00
50cbb727de Fix after merging BLEN-343: Create PreviewEngine.
Bogdan Nagirniak pushed to hydra-render at BogdanNagirniak/blender 2023-03-03 14:55:29 +01:00
722b766d20 BLEN-343: Create PreviewEngine
Bogdan Nagirniak merged pull request BogdanNagirniak/blender#8 2023-03-03 14:55:29 +01:00
BLEN-343: Create PreviewEngine
Bogdan Nagirniak pushed to BLEN-299 at BogdanNagirniak/blender 2023-03-03 10:05:04 +01:00
31873bbf9e Continuing
Bogdan Nagirniak commented on pull request BogdanNagirniak/blender#9 2023-03-03 10:00:10 +01:00
BLEN-356: Automatically configure PXR_MTLX_STDLIB_SEARCH_PATHS

do we need #ifdef WITH_MATERIALX ?

Bogdan Nagirniak suggested changes for BogdanNagirniak/blender#8 2023-03-03 09:39:04 +01:00
BLEN-343: Create PreviewEngine
Bogdan Nagirniak commented on pull request BogdanNagirniak/blender#8 2023-03-03 09:39:04 +01:00
BLEN-343: Create PreviewEngine

check if (!sceneDelegate) instead is_synced

Bogdan Nagirniak commented on pull request BogdanNagirniak/blender#8 2023-03-03 09:39:04 +01:00
BLEN-343: Create PreviewEngine

move to BlenderSceneDelegate class

Bogdan Nagirniak suggested changes for BogdanNagirniak/blender#8 2023-03-02 15:04:11 +01:00
BLEN-343: Create PreviewEngine
Bogdan Nagirniak commented on pull request BogdanNagirniak/blender#8 2023-03-02 15:04:11 +01:00
BLEN-343: Create PreviewEngine

revert this

Bogdan Nagirniak commented on pull request BogdanNagirniak/blender#8 2023-03-02 15:04:11 +01:00
BLEN-343: Create PreviewEngine

Maybe inherit from FinalEngine?

Bogdan Nagirniak pushed to hydra-render at BogdanNagirniak/blender 2023-03-02 12:35:51 +01:00
85864b39a4 BLEN-326: Pass MaterialX to Hydra via hdMaterialNetwork
Bogdan Nagirniak merged pull request BogdanNagirniak/blender#5 2023-03-02 12:35:51 +01:00
BLEN-326: Pass MaterialX to Hydra via hdMaterialNetwork
Bogdan Nagirniak commented on pull request BogdanNagirniak/blender#5 2023-03-01 13:02:23 +01:00
BLEN-326: Pass MaterialX to Hydra via hdMaterialNetwork

Change construction if (...) if (...) .... to if (!...) return; if (!...) return as more understandable and easier to maintain.

Bogdan Nagirniak commented on pull request BogdanNagirniak/blender#5 2023-03-01 13:02:23 +01:00
BLEN-326: Pass MaterialX to Hydra via hdMaterialNetwork

We expect that MaterialX is enabled for hydra_render project. Can be removed.

Bogdan Nagirniak commented on pull request BogdanNagirniak/blender#5 2023-03-01 13:02:23 +01:00
BLEN-326: Pass MaterialX to Hydra via hdMaterialNetwork

This part with _Read() and lambda function is hard to maintain in future + used in one place, can you move it content of _Read here.