Charlie Jolly CharlieJolly
  • Joined on 2008-07-29
Charlie Jolly pushed to gn-hash-node at CharlieJolly/blender 2023-10-11 17:19:35 +02:00
d9bf685dff Merge branch 'main' into gn-hash-node
60ee4f49a5 Change socket names to Value
30574bd8a9 Merge branch 'blender-v4.0-release'
50ed14f228 Fix: Set selection node crashes with attributes on the wrong domain
c52582e3fe Fix: properties search crash
Compare 386 commits »
Charlie Jolly commented on pull request blender/blender#110769 2023-10-10 15:42:15 +02:00
Function Node: Hash Value

@CharlieJolly blender::get_default_hash_2<T, int> (from bli)

From previous review from Jacque it was decided to expose noise::hash functions and not default_hash.

Charlie Jolly commented on pull request blender/blender#110769 2023-10-10 15:15:21 +02:00
Function Node: Hash Value

Also this seems a bit strange in comparison with the other types. I'd propose the following: Add a Seed integer field input, same as the random value node has, for all types. That way…

Charlie Jolly commented on pull request blender/blender#110769 2023-10-10 11:58:44 +02:00
Function Node: Hash Value

To me it's not immediately obvious, why there are 3 inputs for the Integer type. I can see needing 2, but that should be enough to hash any amount of integers together by folding.

The hash…

Charlie Jolly commented on pull request blender/blender#110769 2023-10-10 11:36:12 +02:00
Function Node: Hash Value

hash-to-float was removed, some changes were discussed in chat but the node didn't have any tlc for a while

Charlie Jolly commented on pull request blender/blender#110769 2023-10-06 17:29:52 +02:00
Function Node: Hash Value

The code generally looks good. I think the main thing that's missing in the description is the motivation and examples for how someone should use this. Like, why should this be used instead of…

Charlie Jolly commented on pull request blender/blender#110769 2023-10-05 12:27:28 +02:00
Function Node: Hash Value

Ok, I get what you are saying but we're not consistent here. E.g. Map Range doesn't list all available sockets. Listing all sockets also adds noise that the user needs to go through. In most…

Charlie Jolly commented on pull request blender/blender#110769 2023-10-04 13:38:52 +02:00
Function Node: Hash Value

I'm still not understanding what this is doing different other than using an array and excluding Rotation socks.

Charlie Jolly commented on pull request blender/blender#110769 2023-10-04 12:16:29 +02:00
Function Node: Hash Value

It might be easier for you to provide code if you need me to change something here.

Or are you talking about weight as is done for math node?

Charlie Jolly pushed to gn-hash-node at CharlieJolly/blender 2023-10-04 11:57:37 +02:00
402da08a1a Merge branch 'main' into gn-hash-node
32cb2b2334 Cleanup: avoid having to pass in a statically allocated variable
012289b1e7 Geometry Nodes: deduplicate code to deal with dynamic socket amounts
17bdf18397 Realtime Compositor: Implement Keying Screen node
44ec73e24e Merge branch 'blender-v4.0-release'
Compare 42 commits »
Charlie Jolly commented on pull request blender/blender#110769 2023-10-04 11:56:27 +02:00
Function Node: Hash Value

Sorry, I still don't understand. Drag link only limits by type not node. Hash output is Integer. User might want to plug that into a math node.

Charlie Jolly pushed to gn-hash-node at CharlieJolly/blender 2023-10-04 11:28:02 +02:00
a4ba37825c Move RNA to node
Charlie Jolly commented on pull request blender/blender#110769 2023-10-04 11:27:13 +02:00
Function Node: Hash Value

Maybe you can add a screen shot because I'm not sure I understand.

Charlie Jolly commented on issue blender/blender#109965 2023-10-03 17:26:57 +02:00
Rotation Nodes Design / Splitting Nodes

I'm guessing node vs modes is no longer a proposal. This creates a UI divergence with existing nodes.

Is the Swap Node Operator #111438 going to be a target for 4.1?

![image](/attachments/e6…

Charlie Jolly pushed to gn-hash-node at CharlieJolly/blender 2023-10-03 14:19:47 +02:00
07dbc30b56 White space and header
Charlie Jolly pushed to gn-hash-node at CharlieJolly/blender 2023-10-03 14:16:44 +02:00
bf50a00d11 Fix up build issues after merge.
f7f381d71a Merge branch 'main' into gn-hash-node
ecb7562c74 Merge branch 'blender-v4.0-release'
71732a9600 Fix #113014: Improved sorting to keep node group outputs above inputs
d768c51839 Merge branch 'blender-v4.0-release'
Compare 1963 commits »
Charlie Jolly pushed to gn-easing-node at CharlieJolly/blender 2023-10-03 01:02:32 +02:00
1bf3a692af Move RNA into node
Charlie Jolly commented on pull request blender/blender#109846 2023-10-02 22:17:51 +02:00
Geometry Nodes: Add Random Rotation node

For reference, I previously created a similar node Add Random Spherical Distribution node which had controls to limit the radius, angles. (See https://archive.blender.org/developer/D12746). This…

Charlie Jolly pushed to gn-easing-node at CharlieJolly/blender 2023-10-02 21:43:12 +02:00
5d1fb7eff4 Fix warning