So it is d98005da5df0e2ee6e885b795ecafefa174e3500 to be backported?
You probably have more overview/insight, could you just add the relevant commits to #109399 if appropriate?
I think…
I discussed bug a while back with @Hoshinova and it was included in #111187
I believe this was fixed in #111187 when Musgrave was merged into the Noise texture or this patch.
Fix #112180: Noise with high detail and lacunarity outputs erratic values
Sorry, I've not been active on Blender for a while. Thanks for picking this up.
@SimonThommes I'm not opinionated on the Hash name so I'll leave this for the meeting. One thing to consider is if we add a Hash to Float
node at some point that the naming fits in with this.
@CharlieJolly
blender::get_default_hash_2<T, int>
(frombli
)
From previous review from Jacque it was decided to expose noise::hash
functions and not default_hash
.
Also this seems a bit strange in comparison with the other types. I'd propose the following: Add a Seed integer field input, same as the random value node has, for all types. That way…
To me it's not immediately obvious, why there are 3 inputs for the Integer type. I can see needing 2, but that should be enough to hash any amount of integers together by folding.
The hash…
hash-to-float
was removed, some changes were discussed in chat but the node didn't have any tlc for a while
The code generally looks good. I think the main thing that's missing in the description is the motivation and examples for how someone should use this. Like, why should this be used instead of…
Ok, I get what you are saying but we're not consistent here. E.g. Map Range doesn't list all available sockets. Listing all sockets also adds noise that the user needs to go through. In most…