Charlie Jolly CharlieJolly
  • Joined on 2008-07-29
Charlie Jolly commented on issue blender/blender#100838 2024-02-27 17:00:51 +01:00
Geometry node - setting lacunarity to 0 crashes Blender (musgrave texture) [fine in 4.1, request to ackport]

So it is d98005da5df0e2ee6e885b795ecafefa174e3500 to be backported?

You probably have more overview/insight, could you just add the relevant commits to #109399 if appropriate?

I think…

Charlie Jolly commented on issue blender/blender#100838 2024-02-27 16:05:52 +01:00
Geometry node - setting lacunarity to 0 crashes Blender (musgrave texture) [fine in 4.1, request to ackport]

I discussed bug a while back with @Hoshinova and it was included in #111187

Charlie Jolly commented on issue blender/blender#100838 2024-02-27 16:02:41 +01:00
Geometry node - setting lacunarity to 0 crashes Blender (musgrave texture) [fine in 4.1, request to ackport]

I believe this was fixed in #111187 when Musgrave was merged into the Noise texture or this patch.

Fix #112180: Noise with high detail and lacunarity outputs erratic values

Charlie Jolly commented on pull request blender/blender#110769 2024-02-27 12:36:26 +01:00
Function Node: Hash Value

Sorry, I've not been active on Blender for a while. Thanks for picking this up.

Charlie Jolly pushed to gabor at CharlieJolly/blender 2023-10-26 11:57:34 +02:00
916534f418 Merge branch 'main' into gabor
247491ef0f Merge branch 'blender-v4.0-release'
5d06632565 Fix #114096: Broken thumbnail shadows
72a8851a95 UI Code Quality: Rename UI_ACTIVE button flag to UI_HOVER
af9ffee152 Cycles: Metal: Fix occasional anim corruption (KernelData MD5 refresh bug)
Compare 609 commits »
Charlie Jolly commented on pull request blender/blender#110769 2023-10-12 12:59:55 +02:00
Function Node: Hash Value

@SimonThommes I'm not opinionated on the Hash name so I'll leave this for the meeting. One thing to consider is if we add a Hash to Float node at some point that the naming fits in with this.

Charlie Jolly pushed to gn-integer-math-node at CharlieJolly/blender 2023-10-12 11:22:09 +02:00
b0af7a0850 Merge branch 'main' into gn-integer-math-node
e592763940 Realtime Compositor: Immediately realize transformations
83b23d37e7 EEVEE: Fix Compilation Errors
2316b73a1d Merge branch 'blender-v4.0-release'
4ea76b8530 Fix #113273: Status bar not refreshed when canceling the operation
Compare 2584 commits »
Charlie Jolly pushed to gabor at CharlieJolly/blender 2023-10-12 11:14:49 +02:00
38c607df96 Merge branch 'main' into gabor
e592763940 Realtime Compositor: Immediately realize transformations
83b23d37e7 EEVEE: Fix Compilation Errors
2316b73a1d Merge branch 'blender-v4.0-release'
4ea76b8530 Fix #113273: Status bar not refreshed when canceling the operation
Compare 22 commits »
Charlie Jolly pushed to gabor at CharlieJolly/blender 2023-10-11 23:09:28 +02:00
3cef2a2115 Merge branch 'main' into gabor
59f8712040 Merge branch 'blender-v4.0-release' into main
09046e8121 Fix #113461: Cycles subsurface artifacts with volume interior
5baf173609 Fix #113527: Cycles OSL crash with empty closure for layering
4f5e684e24 Fix Cycles OSL geometry node point cloud inconsistency
Compare 511 commits »
Charlie Jolly commented on pull request blender/blender#110769 2023-10-11 22:55:53 +02:00
Function Node: Hash Value

With Seed socket and one input for each hashable type

image

Charlie Jolly pushed to gn-hash-node at CharlieJolly/blender 2023-10-11 22:54:20 +02:00
6a72a29bda Merge branch 'main' into gn-hash-node
59f8712040 Merge branch 'blender-v4.0-release' into main
09046e8121 Fix #113461: Cycles subsurface artifacts with volume interior
5baf173609 Fix #113527: Cycles OSL crash with empty closure for layering
4f5e684e24 Fix Cycles OSL geometry node point cloud inconsistency
Compare 24 commits »
Charlie Jolly pushed to gn-hash-node at CharlieJolly/blender 2023-10-11 22:52:01 +02:00
47cf039862 Add Seed socket and use this to hash the result
Charlie Jolly pushed to gn-hash-node at CharlieJolly/blender 2023-10-11 17:19:35 +02:00
d9bf685dff Merge branch 'main' into gn-hash-node
60ee4f49a5 Change socket names to Value
30574bd8a9 Merge branch 'blender-v4.0-release'
50ed14f228 Fix: Set selection node crashes with attributes on the wrong domain
c52582e3fe Fix: properties search crash
Compare 386 commits »
Charlie Jolly commented on pull request blender/blender#110769 2023-10-10 15:42:15 +02:00
Function Node: Hash Value

@CharlieJolly blender::get_default_hash_2<T, int> (from bli)

From previous review from Jacque it was decided to expose noise::hash functions and not default_hash.

Charlie Jolly commented on pull request blender/blender#110769 2023-10-10 15:15:21 +02:00
Function Node: Hash Value

Also this seems a bit strange in comparison with the other types. I'd propose the following: Add a Seed integer field input, same as the random value node has, for all types. That way…

Charlie Jolly commented on pull request blender/blender#110769 2023-10-10 11:58:44 +02:00
Function Node: Hash Value

To me it's not immediately obvious, why there are 3 inputs for the Integer type. I can see needing 2, but that should be enough to hash any amount of integers together by folding.

The hash…

Charlie Jolly commented on pull request blender/blender#110769 2023-10-10 11:36:12 +02:00
Function Node: Hash Value

hash-to-float was removed, some changes were discussed in chat but the node didn't have any tlc for a while

Charlie Jolly commented on pull request blender/blender#110769 2023-10-06 17:29:52 +02:00
Function Node: Hash Value

The code generally looks good. I think the main thing that's missing in the description is the motivation and examples for how someone should use this. Like, why should this be used instead of…

Charlie Jolly commented on pull request blender/blender#110769 2023-10-05 12:27:28 +02:00
Function Node: Hash Value

Ok, I get what you are saying but we're not consistent here. E.g. Map Range doesn't list all available sockets. Listing all sockets also adds noise that the user needs to go through. In most…