Charlie Jolly CharlieJolly
  • Joined on 2008-07-29
Charlie Jolly commented on pull request blender/blender#110802 2023-08-31 16:55:02 +02:00
WIP: Node: Gabor Noise Texture

I think we should reconsider the big picture here. I don't think we should continue to add thousands of lines of code (which bloats the Cycles kernel, has to be maintained, refactored, optimized…

Charlie Jolly commented on pull request blender/blender#110802 2023-08-31 16:36:59 +02:00
WIP: Node: Gabor Noise Texture

@CharlieJolly Can't we just increase the cutoff point of truncating the gabor kernel?

To quote the paper:

If required, this discontinuity could be alleviated by truncating at a…

Charlie Jolly commented on pull request blender/blender#110802 2023-08-31 15:57:16 +02:00
WIP: Node: Gabor Noise Texture

Gabor noise does exhibit some discontinuities because the gaussian envelope is not continuous.

This is noted in Tavernier et. al. 2018, Gabor noise revisited which includes the improved…

Charlie Jolly commented on pull request blender/blender#110802 2023-08-30 17:41:24 +02:00
WIP: Node: Gabor Noise Texture

@blender-bot package

Charlie Jolly pushed to gabor at CharlieJolly/blender 2023-08-30 17:40:06 +02:00
f2c8f0f888 Merge branch 'main' into gabor
605c62c121 Move Cell Randomness to bottom like in Voronoi
e56b1fc164 Cleanup: Make SubdivCCG a non-trivial struct
fdd6065c21 Cleanup: Add missing struct forward declaration
62c898f2e0 Fix (DY)LD_LIBRARY_PATH ignored for oslc and shader builder in build
Compare 10 commits »
Charlie Jolly pushed to gabor at CharlieJolly/blender 2023-08-30 16:22:06 +02:00
7d9e2047da Merge branch 'main' into gabor
0fbe56c39c Merge branch 'main' into gabor
770f5045b5 Cleanup: Move generic validity checks on blend data to DEBUG report.
152f5dc897 Fix #111633: crash with cyclic node tree zones
290e3bd066 Comments
Compare 24 commits »
Charlie Jolly pushed to gabor at CharlieJolly/blender 2023-08-30 01:10:12 +02:00
335e367716 Merge branch 'main' into gabor
6db2eb0023 Fix error in last commit
ddbe073a6d Cleanup: Typo in prior commit.
468584f5e7 UI: Handle lack of active area in NewGeometryNodeGroupTool poll
6d2c7c509c Fix: failing keymap test for ARMATURE_OT_assign_to_collection
Compare 36 commits »
Charlie Jolly commented on pull request blender/blender#110802 2023-08-29 18:29:09 +02:00
WIP: Node: Gabor Noise Texture

Please stop this project and look into adding loops to shaders and reworking all fractal noise texture types into a node group asset)

Voronoi and Noise have both recently had fractal noise…

Charlie Jolly commented on pull request blender/blender#110802 2023-08-29 18:00:49 +02:00
WIP: Node: Gabor Noise Texture

The number of inputs is definitely increased by adding the fractal controls. Removing those alone would reduce inputs by five but at the loss of that feature.

Charlie Jolly commented on pull request blender/blender#110802 2023-08-29 17:02:38 +02:00
WIP: Node: Gabor Noise Texture

Okay, so why not remove the enum, rename Rotation Variance to Anisotropy, and unify the Direction and Rotation inputs?

I did think about this but found it tricky to do this in a nice way. The…

Charlie Jolly commented on pull request blender/blender#110802 2023-08-29 16:49:45 +02:00
WIP: Node: Gabor Noise Texture

Yes, in OSL implementation we have the angular frequency set to a random number

float omega_t = float(M_TWO_PI) * rng();

in this patch this is contolled by Rotation and Rotation…

Charlie Jolly commented on pull request blender/blender#110802 2023-08-29 16:41:04 +02:00
WIP: Node: Gabor Noise Texture

@OmarEmaraDev this is achieved using the Rotation and Rotation Variance controls.

Charlie Jolly pushed to gabor at CharlieJolly/blender 2023-08-29 16:19:40 +02:00
784a1131ed Address comments
8979689d8a Merge branch 'main' into gabor
cc01bb83f6 Fix #111490: paint radius set to 1 (shift-smoothing but brush missing)
a69352824e Cleanup: simplify terms in EEVEE multiscatter GGX
f518e86128 Cleanup: remove unused function
Compare 176 commits »
Charlie Jolly commented on pull request blender/blender#110802 2023-08-29 16:15:28 +02:00
WIP: Node: Gabor Noise Texture

This scaling factor here was simplification used in a script implementation by Lee Bruemmer.

The OSL reference uses the following based on the bandwidth value.

float gabor_variance =…
Charlie Jolly commented on pull request blender/blender#110802 2023-08-29 16:03:34 +02:00
WIP: Node: Gabor Noise Texture

Well TBH I'm not sure, reading it again this looks like a feature of their application which is no longer available it seems. In this case I believe this can be achieved using the Rotation…

Charlie Jolly commented on pull request blender/blender#110802 2023-08-29 15:56:05 +02:00
WIP: Node: Gabor Noise Texture

Added note to gabor_kernel function, this is due to returning Phasor values.

Charlie Jolly commented on pull request blender/blender#110802 2023-08-29 15:42:31 +02:00
WIP: Node: Gabor Noise Texture

Added comment to define: e^(-PI)

Charlie Jolly commented on pull request blender/blender#110802 2023-08-29 15:36:06 +02:00
WIP: Node: Gabor Noise Texture

I can add back the Hybrid mode.

Charlie Jolly commented on pull request blender/blender#111168 2023-08-25 01:53:18 +02:00
Fix #111017: Gap between color square and frame of box in the color ramp

Just for sentimental reasons, the old color ramp.

image

Charlie Jolly commented on pull request blender/blender#111401 2023-08-24 02:17:13 +02:00
WIP: Nodes: Add Hexagon Grid Texture node

I'm leaning towards the fact that part of the outputs is literally a other output + a math node (fract, floor, min, smooth min, rand, ...).

That might be the case, but most of this data is…