Charlie Jolly CharlieJolly
  • Joined on 2008-07-29
Charlie Jolly commented on pull request blender/blender#110802 2023-08-21 17:04:02 +02:00
WIP: Node: Gabor Noise Texture

Is this a redundant optimisation?

Charlie Jolly commented on pull request blender/blender#110802 2023-08-21 17:00:51 +02:00
WIP: Node: Gabor Noise Texture

It's useful to allow impulses less than 1 to create spotted textures which is why int(impulses) is not directly used. Above 1 this provides a smooth increase in impulses as the input value…

Charlie Jolly commented on pull request blender/blender#110802 2023-08-21 17:00:49 +02:00
WIP: Node: Gabor Noise Texture

It's useful to allow impulses less than 1 to create spotted textures which is why int(impulses) is not directly used. Above 1 this provides a smooth increase in impulses as the input value…

Charlie Jolly pushed to gabor at CharlieJolly/blender 2023-08-20 19:12:13 +02:00
0aeb0b8fe6 Skip this cells if they are too far away to contribute - from Lee Bruemmer.osl
57b8b8208a Move bandwidth multiplication outside loop
1b53cd0928 Change kernel to mode
Compare 3 commits »
Charlie Jolly commented on pull request blender/blender#110802 2023-08-20 17:33:47 +02:00
WIP: Node: Gabor Noise Texture

This differs between noise and voronoi, I'm not sure which one is actually preferable. If the input is driven then it may make sense to keep it as is so the transition from 0 to 1 is smoother. The…

Charlie Jolly commented on pull request blender/blender#110802 2023-08-20 14:32:12 +02:00
WIP: Node: Gabor Noise Texture

Lacunarity fix image

Charlie Jolly commented on pull request blender/blender#110802 2023-08-20 14:25:22 +02:00
WIP: Node: Gabor Noise Texture

Removed this clause.

Charlie Jolly pushed to gabor at CharlieJolly/blender 2023-08-20 14:20:20 +02:00
cb921981ea Merge branch 'main' into gabor
38d3511132 Match other noise behaviour when lacunarity is zero
39a40d6f84 Cleanup: Subdiv: Replace "stack or buffer" storage with C++ classes
b25b13a90b Fix #111278: UI Text Extension of Selection
Compare 4 commits »
Charlie Jolly pushed to gabor at CharlieJolly/blender 2023-08-19 20:00:41 +02:00
8e93e7cab7 Tweak ui
d8474af870 Add some missing const
4627b0760c Make normalize default to on
Compare 3 commits »
Charlie Jolly commented on pull request blender/blender#110802 2023-08-19 18:04:20 +02:00
WIP: Node: Gabor Noise Texture

@blender-bot package

Charlie Jolly pushed to gabor at CharlieJolly/blender 2023-08-19 18:04:09 +02:00
231be540a3 Fix build issues raised on build bot
Charlie Jolly commented on pull request blender/blender#110802 2023-08-19 17:40:50 +02:00
WIP: Node: Gabor Noise Texture

@blender-bot package

Charlie Jolly commented on pull request blender/blender#110802 2023-08-19 17:39:50 +02:00
WIP: Node: Gabor Noise Texture

This is partly implemented in Cycles using constant folding. Do you have an example for Eevee?

Charlie Jolly commented on pull request blender/blender#110802 2023-08-19 17:37:20 +02:00
WIP: Node: Gabor Noise Texture

This has been slightly refactored but combining to a single factor is not feasible for Gabor noise.

Charlie Jolly commented on pull request blender/blender#110802 2023-08-19 17:35:06 +02:00
WIP: Node: Gabor Noise Texture

Updated to use built in hash functions

Charlie Jolly commented on pull request blender/blender#110802 2023-08-19 17:34:28 +02:00
WIP: Node: Gabor Noise Texture

Implemented fractal based on other noise functions.

Charlie Jolly pushed to gabor at CharlieJolly/blender 2023-08-19 17:33:41 +02:00
403d99b5d3 Merge branch 'main' into gabor
5a8cb665e0 Cleanup: various non-functional C++ changes
faa3ef6ad5 Cleanup: format
9d08be1eec Realtime Compositor: add regression tests
4f72240c1d Cleanup: spelling (correct correction), update dictionary
Compare 35 commits »
Charlie Jolly pushed to gabor at CharlieJolly/blender 2023-08-19 17:30:18 +02:00
a243de001a + Added Normalisation and Fractal options, removing previous implementation of fractal noise
c0805ea670 Fix issues after changes in master
cde5059f12 Fix unintentional change in Wave texture node
c6fb7f420e Merge branch 'main' into gabor
726ba534fc Realtime Compositor: Support realization of transformations
Compare 295 commits »
Charlie Jolly commented on pull request blender/blender#110802 2023-08-18 11:09:51 +02:00
WIP: Node: Gabor Noise Texture

Fixed locally. Although it does highlight we have different terminology here "Detail Scale" vs "Lacunarity".

Charlie Jolly commented on pull request blender/blender#110802 2023-08-15 00:06:55 +02:00
WIP: Node: Gabor Noise Texture

To be honest, I don't think the patch is ready for review because it lacks any kind of documentation, either in the code or in the patch description.

Even the only given reference "Lagae,…