Charlie Jolly CharlieJolly
  • Joined on 2008-07-29
Charlie Jolly pushed to node-drag-link at CharlieJolly/blender 2024-09-19 17:14:26 +02:00
0ad4094e84 Nodes: Improve matches when dragging a node onto a link
Charlie Jolly commented on pull request blender/blender#110735 2024-09-18 20:07:48 +02:00
Function Node: Integer Math node

@blender-bot package

Charlie Jolly pushed to gn-integer-math-node at CharlieJolly/blender 2024-09-18 20:06:16 +02:00
dfda89c41d Merge branch 'main' into gn-integer-math-node
42b390fe3d Fix #127510: Crash when registering panel as instanced
0d76071289 Build: Add option to remove stale files from checkout
721ece9efb Cleanup: Sculpt: Move automasking functions to proper header
4a45ae7393 Nodes: rename "unavailable" to "available" in node declaration
Compare 18 commits »
Charlie Jolly commented on pull request blender/blender#110735 2024-09-18 20:03:52 +02:00
Function Node: Integer Math node

Last commit, make menu smaller

image
Charlie Jolly pushed to gn-integer-math-node at CharlieJolly/blender 2024-09-18 20:02:40 +02:00
cc763c2fc2 Tweak menu - make it narrower
Charlie Jolly pushed to gn-integer-math-node at CharlieJolly/blender 2024-09-18 17:42:05 +02:00
a15b185a33 Address code comments. Some subjective changes have been left.
Charlie Jolly commented on pull request blender/blender#110735 2024-09-18 14:38:53 +02:00
Function Node: Integer Math node

Placeholder for replying to comments in code review.

Charlie Jolly commented on pull request blender/blender#110735 2024-09-18 14:03:43 +02:00
Function Node: Integer Math node

Correct terms are used. These are not division operators.

Charlie Jolly commented on pull request blender/blender#110735 2024-09-18 14:01:08 +02:00
Function Node: Integer Math node

Intention was to provide Integer based functions. Whether these are better suited to another node is subjective, there is currently separation in the menu layout for these ops. Personally I prefer…

Charlie Jolly commented on pull request blender/blender#110735 2024-09-18 13:58:18 +02:00
Function Node: Integer Math node

Not meaningless, it is the absolute distance between the numbers. E.g. -5 to 3 is 8.

Charlie Jolly commented on pull request blender/blender#110735 2024-09-18 13:55:33 +02:00
Function Node: Integer Math node

That's why there is both a modulo and remainder function. Modulo is periodic with negative numbers. Remainder is the standard % operator.

Charlie Jolly commented on pull request blender/blender#110735 2024-09-18 13:50:31 +02:00
Function Node: Integer Math node

See comment below.

Charlie Jolly commented on pull request blender/blender#110735 2024-09-18 13:50:08 +02:00
Function Node: Integer Math node

See comment below.

Charlie Jolly commented on pull request blender/blender#110735 2024-09-18 13:49:01 +02:00
Function Node: Integer Math node

There was a time when storage was preferred as it is more explicit but it seems this has changed now.

Charlie Jolly commented on pull request blender/blender#110735 2024-09-18 13:34:58 +02:00
Function Node: Integer Math node

Yes to make the operation safe, much like safe_divide.

Charlie Jolly commented on pull request blender/blender#110735 2024-09-18 13:34:42 +02:00
Function Node: Integer Math node

Yes to make the operation safe, much like safe_divide.

Charlie Jolly commented on pull request blender/blender#110735 2024-09-18 00:34:20 +02:00
Function Node: Integer Math node
Charlie Jolly pushed to gn-integer-math-node at CharlieJolly/blender 2024-09-18 00:33:32 +02:00
429f1bf635 Lint error
Charlie Jolly commented on pull request blender/blender#110735 2024-09-18 00:29:48 +02:00
Function Node: Integer Math node
Charlie Jolly pushed to gn-integer-math-node at CharlieJolly/blender 2024-09-18 00:28:29 +02:00
6eb5da42fb Merge branch 'main' into gn-integer-math-node
60be9fb8e2 Fix divide by zero bug
51e9a36c2f Cycles: oneAPI: build binaries for Lunar Lake GPUs
9db50bed04 Fix: Geometry Nodes: use better hash for InstanceReference
2ba69519a8 Fix #127678: Auto-Save Preferences does not work for few anim properties
Compare 11 commits »