- mostly Madrid
- http://www.christoph.lendenfeld.at/
-
I used to be an animator like you, but then I took an "oh you can code" to the knee
- Joined on
2020-01-09 -
-
only ale can be const in this case
because ANIM_get_normalization_flags and ANIM_unit_mapping_get_factor would throw warnings otherwise since they aren't set to const
I think B would be better.
Fix it first, then make it better
@sybren that means the middle mouse drag behaviour is now inconsistent between the channel box and the keyframe view (I mean it was already inconsistent before the patch but anyway) I think it…
using const Span<MLoop> poly_loops = loops.slice(poly.loopstart, poly.totloop); as you suggested also solved that issue :)
sure thing, missed that out of curiosity: what is the reason for it?
My idea was that it makes it explicit what the function is doing. I thought it's not immediately obvious that it would stop at seams.
Let me know what you think. I can remove it until needed…
@HooglyBoogly
I had a look at FaceSetFromBoundariesInput honestly I didn't even think of using a map. It could work though if there is a way to ignore hidden faces and seams.
I changed out all for loops except for (int inner_loop_index = outer_loop_index + 1; inner_loop_index < poly.totloop; inner_loop_index++)
I found it a bit confusing to use IndexRange for…