Christoph Lendenfeld ChrisLend
Christoph Lendenfeld pushed to main at ChrisLend/.profile 2024-03-28 15:17:12 +01:00
78b7033622 Update reports/2024.md
Christoph Lendenfeld pushed to main at blender/blender 2024-03-28 15:14:16 +01:00
6276dd2f64 Fix #119946: NLA stack decomposition doesn't work with bones
Christoph Lendenfeld deleted branch fix_nla_decomp_with_bones from ChrisLend/blender 2024-03-28 15:14:15 +01:00
Christoph Lendenfeld closed issue blender/blender#119946 2024-03-28 15:14:14 +01:00
Blender 4.1 NLA Combine blend type is Broken
Christoph Lendenfeld merged pull request blender/blender#120008 2024-03-28 15:14:12 +01:00
Fix #119946: NLA stack decomposition doesn't work with bones
Christoph Lendenfeld commented on pull request blender/blender#119388 2024-03-28 15:06:02 +01:00
Anim: run bezier handle calculation in parallel

where is the number 4096 coming from? hardware limits?

Christoph Lendenfeld commented on pull request blender/blender#119388 2024-03-28 15:02:19 +01:00
Anim: run bezier handle calculation in parallel

I did and surprisingly it got slower with 256 and 512. But then again that's on a sample size of 1. Not sure if there are machine differences. And the difference wasn't huge, ~10% with quite a bit…

Christoph Lendenfeld pushed to thread_recalc_handles at ChrisLend/blender 2024-03-28 14:52:59 +01:00
7f2a221ad3 Merge branch 'main' into thread_recalc_handles
362d381a5a Cleanup: pass GPUStateMutable as a const reference
e7abad23e0 Fix #118696: Nested override libraries can cause persistent resync warning.
b4517ca148 Cleanup: replace suspicious use of "&" with "&&"
0ef033750f Cleanup: pass arguments by const reference
Compare 120 commits »
Christoph Lendenfeld pushed to fix_nla_decomp_with_bones at ChrisLend/blender 2024-03-28 14:46:15 +01:00
2d705d89ba declaration into if
Christoph Lendenfeld commented on pull request blender/blender#120008 2024-03-28 12:54:48 +01:00
Fix #119946: NLA stack decomposition doesn't work with bones

moved the comment to the function body, modified the docstring on the function to specifically mention IDs and added an assert

Is it save to add asserts when this will be backported to 4.1?

Christoph Lendenfeld pushed to fix_nla_decomp_with_bones at ChrisLend/blender 2024-03-28 12:51:44 +01:00
087221fd82 move comment and add assert
Christoph Lendenfeld pushed to main at ChrisLend/.profile 2024-03-28 12:19:57 +01:00
fd7179bdfc Update reports/2024.md
Christoph Lendenfeld created pull request blender/blender#120008 2024-03-28 12:16:35 +01:00
Fix #119946: NLA stack decomposition doesn't work with bones
Christoph Lendenfeld pushed to fix_nla_decomp_with_bones at ChrisLend/blender 2024-03-28 12:13:51 +01:00
60060fbfd6 the fix
Christoph Lendenfeld created branch fix_nla_decomp_with_bones in ChrisLend/blender 2024-03-28 12:13:50 +01:00
Christoph Lendenfeld pushed to main at ChrisLend/blender 2024-03-28 12:13:40 +01:00
362d381a5a Cleanup: pass GPUStateMutable as a const reference
e7abad23e0 Fix #118696: Nested override libraries can cause persistent resync warning.
b4517ca148 Cleanup: replace suspicious use of "&" with "&&"
0ef033750f Cleanup: pass arguments by const reference
4e650294e2 Fix #119184: Crash due to extremely broken liboverrides.
Compare 119 commits »
Christoph Lendenfeld commented on issue blender/blender#119946 2024-03-28 11:53:23 +01:00
Blender 4.1 NLA Combine blend type is Broken

so this is only an issue with bones, objects are ok. The issue seems to be that we pass the PointerRNA of the bone to the NLA stack decomposition which doesn't work. It needs to get the pointer…

Christoph Lendenfeld commented on issue blender/blender#119946 2024-03-28 09:18:04 +01:00
Blender 4.1 NLA Combine blend type is Broken

thanks, will take a look today