- mostly Madrid
- http://www.christoph.lendenfeld.at/
-
I used to be an animator like you, but then I took an "oh you can code" to the knee
- Joined on
2020-01-09
Christoph Lendenfeld
deleted branch fix_nla_decomp_with_bones from ChrisLend/blender
2024-03-28 15:14:15 +01:00
Blender 4.1 NLA Combine blend type is Broken
Fix #119946: NLA stack decomposition doesn't work with bones
Anim: run bezier handle calculation in parallel
where is the number 4096 coming from? hardware limits?
Anim: run bezier handle calculation in parallel
I did and surprisingly it got slower with 256 and 512. But then again that's on a sample size of 1. Not sure if there are machine differences. And the difference wasn't huge, ~10% with quite a bit…
Christoph Lendenfeld
pushed to thread_recalc_handles at ChrisLend/blender
2024-03-28 14:52:59 +01:00
7f2a221ad3
Merge branch 'main' into thread_recalc_handles
362d381a5a
Cleanup: pass GPUStateMutable as a const reference
e7abad23e0
Fix #118696: Nested override libraries can cause persistent resync warning.
b4517ca148
Cleanup: replace suspicious use of "&" with "&&"
0ef033750f
Cleanup: pass arguments by const reference
Christoph Lendenfeld
pushed to fix_nla_decomp_with_bones at ChrisLend/blender
2024-03-28 14:46:15 +01:00
2d705d89ba
declaration into if
Fix #119946: NLA stack decomposition doesn't work with bones
moved the comment to the function body, modified the docstring on the function to specifically mention IDs and added an assert
Is it save to add asserts when this will be backported to 4.1?
Christoph Lendenfeld
pushed to fix_nla_decomp_with_bones at ChrisLend/blender
2024-03-28 12:51:44 +01:00
087221fd82
move comment and add assert
Fix #119946: NLA stack decomposition doesn't work with bones
Christoph Lendenfeld
pushed to fix_nla_decomp_with_bones at ChrisLend/blender
2024-03-28 12:13:51 +01:00
60060fbfd6
the fix
Christoph Lendenfeld
created branch fix_nla_decomp_with_bones in ChrisLend/blender
2024-03-28 12:13:50 +01:00
362d381a5a
Cleanup: pass GPUStateMutable as a const reference
e7abad23e0
Fix #118696: Nested override libraries can cause persistent resync warning.
b4517ca148
Cleanup: replace suspicious use of "&" with "&&"
0ef033750f
Cleanup: pass arguments by const reference
4e650294e2
Fix #119184: Crash due to extremely broken liboverrides.
Blender 4.1 NLA Combine blend type is Broken
so this is only an issue with bones, objects are ok.
The issue seems to be that we pass the PointerRNA
of the bone to the NLA stack decomposition which doesn't work. It needs to get the pointer…