DagerD
/
blender
forked from blender/blender
1
1
Fork 0
Code Pull Requests Activity

Fix linux build #33

Merged
Bogdan Nagirniak merged 7 commits from BogdanNagirniak/blender:matx-linux-build-fix into matx-export-material 2023-09-24 07:42:31 +02:00
Conversation 0 Commits 7 Files Changed 5 +110 -61
Bogdan Nagirniak commented 2023-09-23 00:22:31 +02:00
Collaborator
Copy Link

Purpose

Errors in linux build https://builder.blender.org/admin/#/builders/132/builds/2398. Issues in group nodes.

Technical steps

  1. Fixed linux build: set math functions names to convenience.
  2. Fixed some issues in group nodes. Made better naming of inputs and outputs in nodegraph for group node.
  3. make format
### Purpose Errors in linux build https://builder.blender.org/admin/#/builders/132/builds/2398. Issues in group nodes. ### Technical steps 1. Fixed linux build: set math functions names to convenience. 2. Fixed some issues in group nodes. Made better naming of inputs and outputs in `nodegraph` for group node. 3. `make format`
Bogdan Nagirniak added 4 commits 2023-09-23 00:22:47 +02:00
Bogdan Nagirniak changed title from matx-linux-build-fix to Fix linux build 2023-09-23 00:23:11 +02:00
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-09-23 00:23:16 +02:00
Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-09-23 00:23:16 +02:00
Georgiy Markelov was assigned by Bogdan Nagirniak 2023-09-23 00:23:27 +02:00
Bogdan Nagirniak self-assigned this 2023-09-23 00:23:28 +02:00
Vasyl Pidhirskyi requested changes 2023-09-23 15:03:37 +02:00
source/blender/nodes/shader/materialx/group_nodes.cc
@ -128,4 +124,1 @@
if (NodeItem::is_arithmetic(to_type_)) {
return group_parser_->get_input_value(socket_out_->index(), to_type_);
}
return group_parser_->get_input_link(socket_out_->index(), to_type_);
Vasyl Pidhirskyi commented 2023-09-23 14:48:07 +02:00
Collaborator
Copy Link

get_input_value(...
Otherwise, the input socket's default value is ignored.

`get_input_value(...` Otherwise, the input socket's default value is ignored.
BogdanNagirniak marked this conversation as resolved
Bogdan Nagirniak added 3 commits 2023-09-24 07:01:06 +02:00
Vasyl Pidhirskyi approved these changes 2023-09-24 07:25:32 +02:00
Vasyl Pidhirskyi left a comment
Collaborator
Copy Link

Node groups work as expected.

Node groups work as expected.
Bogdan Nagirniak merged commit 1132957f48 into matx-export-material 2023-09-24 07:42:31 +02:00
Bogdan Nagirniak referenced this issue from a commit 2023-09-24 07:42:33 +02:00
Fix linux build
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Vasyl Pidhirskyi
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Georgiy Markelov
Bogdan Nagirniak
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: DagerD/blender#33
No description provided.
Delete Branch "BogdanNagirniak/blender:matx-linux-build-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?