DagerD
/
blender
forked from blender/blender
1
1
Fork 0
Code Pull Requests Activity

MaterialX logging #7

Merged
Bogdan Nagirniak merged 3 commits from BogdanNagirniak/blender:matx-logging into matx-export-material 2023-08-31 20:11:18 +02:00
Conversation 0 Commits 3 Files Changed 8 +62 -34
Bogdan Nagirniak commented 2023-08-31 20:01:43 +02:00
Collaborator
Copy Link

Purpose

Change debug printf to CLOG logger. Add other logging.

Technical steps

  1. Applied CLOG logger to bf_nodes_shader project.
  2. Changed debug printf to logging. Added other logging.
  3. Fixed "Use MaterialX" in rna_render.cc.

Notes

Don't use --log-show-basename blender running flag in Windows, because of clog crash due to incorrect path separator for bf_nodes_shader project.

### Purpose Change debug printf to CLOG logger. Add other logging. ### Technical steps 1. Applied CLOG logger to `bf_nodes_shader` project. 2. Changed debug `printf` to logging. Added other logging. 3. Fixed "Use MaterialX" in `rna_render.cc`. ### Notes Don't use `--log-show-basename` blender running flag in Windows, because of clog crash due to incorrect path separator for `bf_nodes_shader` project.
Bogdan Nagirniak added 3 commits 2023-08-31 20:02:04 +02:00
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-08-31 20:02:10 +02:00
Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-08-31 20:02:10 +02:00
Georgiy Markelov was assigned by Bogdan Nagirniak 2023-08-31 20:02:15 +02:00
Bogdan Nagirniak self-assigned this 2023-08-31 20:02:22 +02:00
Georgiy Markelov approved these changes 2023-08-31 20:10:09 +02:00
Georgiy Markelov left a comment
Owner
Copy Link

Works fine.

Works fine.
Bogdan Nagirniak merged commit fa0aea502f into matx-export-material 2023-08-31 20:11:18 +02:00
Bogdan Nagirniak referenced this issue from a commit 2023-08-31 20:11:19 +02:00
MaterialX logging
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Vasyl Pidhirskyi
Georgiy Markelov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Georgiy Markelov
Bogdan Nagirniak
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: DagerD/blender#7
No description provided.
Delete Branch "BogdanNagirniak/blender:matx-logging"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?