@HooglyBoogly if I look in files changed then the changes are there. I don't know why it will not show them to you, maybe there is some bug becouse arye merged a pull request from me into his…
I am hoping its clearer now. this section makes sure generic output attributes exists so later code can be better optimaized.
Ok didn't see that it is basically a wrapped pointer.
Isn't it more costly to create a local GeometrySet and then copy twice it in the return than to use an output param?.
The change was done because this switch case was needed in two places. Here and in attribute_foreach. It was put into a separate function and instead of creating a local GeometrySet and calling…
Sure. @mod_moder requested that change in a prior review. Can be reverted here and be done in a later PR.
Can someone confirm that the crash is still happening? I couldn't reproduce it myself in either linux or windows and when looking at Mac - Blender Assert Back Trace.txt I saw that the code have…
The problem seems to be that the WM_set_locked_interface(job->wm, true); happens inside the thread and then the main thread may check the lock while the thread is in the middle of changing it. I…
where can I read about ASAN? I tried googling it but did not find anything relevant. after changing the code to always use BakeRequestsMode::Sync I wasn't able to reproudce the crash. if no one…